netdev - Re: [PATCH net-next v2] ip6_tunnel: enable to change proto of fb tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202506280734.J8kwhuua-lkp@intel.com>
Date: Sat, 28 Jun 2025 08:06:22 +0800
From: kernel test robot <lkp@...el.com>
To: Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	"David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>, Simon Horman <horms@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Subject: Re: [PATCH net-next v2] ip6_tunnel: enable to change proto of fb
 tunnels

Hi Nicolas,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Nicolas-Dichtel/ip6_tunnel-enable-to-change-proto-of-fb-tunnels/20250627-060113
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250626215919.2825347-1-nicolas.dichtel%406wind.com
patch subject: [PATCH net-next v2] ip6_tunnel: enable to change proto of fb tunnels
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20250628/202506280734.J8kwhuua-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250628/202506280734.J8kwhuua-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506280734.J8kwhuua-lkp@intel.com/

All warnings (new ones prefixed by >>):

   net/ipv6/ip6_tunnel.c: In function 'ip6_tnl_changelink':
>> net/ipv6/ip6_tunnel.c:2068:33: warning: unused variable 't' [-Wunused-variable]
    2068 |                 struct ip6_tnl *t = netdev_priv(ip6n->fb_tnl_dev);
         |                                 ^


vim +/t +2068 net/ipv6/ip6_tunnel.c

  2056	
  2057	static int ip6_tnl_changelink(struct net_device *dev, struct nlattr *tb[],
  2058				      struct nlattr *data[],
  2059				      struct netlink_ext_ack *extack)
  2060	{
  2061		struct ip6_tnl *t = netdev_priv(dev);
  2062		struct __ip6_tnl_parm p;
  2063		struct net *net = t->net;
  2064		struct ip6_tnl_net *ip6n = net_generic(net, ip6_tnl_net_id);
  2065		struct ip_tunnel_encap ipencap;
  2066	
  2067		if (dev == ip6n->fb_tnl_dev) {
> 2068			struct ip6_tnl *t = netdev_priv(ip6n->fb_tnl_dev);
  2069	
  2070			if (ip_tunnel_netlink_encap_parms(data, &ipencap)) {
  2071				/* iproute2 always sets TUNNEL_ENCAP_FLAG_CSUM6, so
  2072				 * let's ignore this flag.
  2073				 */
  2074				ipencap.flags &= ~TUNNEL_ENCAP_FLAG_CSUM6;
  2075				if (memchr_inv(&ipencap, 0, sizeof(ipencap))) {
  2076					NL_SET_ERR_MSG(extack,
  2077						       "Only protocol can be changed for fallback tunnel, not encap params");
  2078					return -EINVAL;
  2079				}
  2080			}
  2081	
  2082			ip6_tnl_netlink_parms(data, &p);
  2083			if (ip6_tnl0_update(netdev_priv(ip6n->fb_tnl_dev), &p,
  2084					    true) < 0) {
  2085				NL_SET_ERR_MSG(extack,
  2086					       "Only protocol can be changed for fallback tunnel");
  2087				return -EINVAL;
  2088			}
  2089	
  2090			return 0;
  2091		}
  2092	
  2093		if (ip_tunnel_netlink_encap_parms(data, &ipencap)) {
  2094			int err = ip6_tnl_encap_setup(t, &ipencap);
  2095	
  2096			if (err < 0)
  2097				return err;
  2098		}
  2099		ip6_tnl_netlink_parms(data, &p);
  2100		if (p.collect_md)
  2101			return -EINVAL;
  2102	
  2103		t = ip6_tnl_locate(net, &p, 0);
  2104		if (!IS_ERR(t)) {
  2105			if (t->dev != dev)
  2106				return -EEXIST;
  2107		} else
  2108			t = netdev_priv(dev);
  2109	
  2110		ip6_tnl_update(t, &p);
  2111		return 0;
  2112	}
  2113	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki