netdev - Re: [net-next, v2 04/10] bng_en: Add initial interaction with firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250627172210.5d42e0f1@kernel.org>
Date: Fri, 27 Jun 2025 17:22:10 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Vikas Gupta <vikas.gupta@...adcom.com>
Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 andrew+netdev@...n.ch, horms@...nel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, michael.chan@...adcom.com,
 pavan.chebbi@...adcom.com, vsrama-krishna.nemani@...adcom.com, Bhargava
 Chenna Marreddy <bhargava.marreddy@...adcom.com>, Rajashekar Hudumula
 <rajashekar.hudumula@...adcom.com>
Subject: Re: [net-next, v2 04/10] bng_en: Add initial interaction with
 firmware

On Thu, 26 Jun 2025 14:08:13 +0000 Vikas Gupta wrote:
> @@ -128,10 +175,26 @@ static int bnge_probe_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  		goto err_devl_unreg;
>  	}
>  
> +	rc = bnge_init_hwrm_resources(bd);
> +	if (rc)
> +		goto err_bar_unmap;
> +
> +	rc = bnge_fw_register_dev(bd);
> +	if (rc) {
> +		dev_err(&pdev->dev, "Failed to register with firmware rc = %d\n", rc);
> +		goto err_hwrm_cleanup;
> +	}

you're adding this _after_ devlink has been registered
users can access the devlink ops before you finished init
-- 
pw-bot: cr