netdev - RE: [PATCH v20 net-next 6/6] Documentation: netlink: specs: tc: Add DualPI2 specification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR07MB79842E86F802F227C79C05F6A347A@PAXPR07MB7984.eurprd07.prod.outlook.com>
Date: Sun, 29 Jun 2025 22:32:15 +0000
From: "Chia-Yu Chang (Nokia)" <chia-yu.chang@...ia-bell-labs.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "alok.a.tiwari@...cle.com" <alok.a.tiwari@...cle.com>,
	"pctammela@...atatu.com" <pctammela@...atatu.com>, "horms@...nel.org"
	<horms@...nel.org>, "donald.hunter@...il.com" <donald.hunter@...il.com>,
	"xandfury@...il.com" <xandfury@...il.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "dave.taht@...il.com" <dave.taht@...il.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "jhs@...atatu.com"
	<jhs@...atatu.com>, "stephen@...workplumber.org"
	<stephen@...workplumber.org>, "xiyou.wangcong@...il.com"
	<xiyou.wangcong@...il.com>, "jiri@...nulli.us" <jiri@...nulli.us>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"ast@...erby.net" <ast@...erby.net>, "liuhangbin@...il.com"
	<liuhangbin@...il.com>, "shuah@...nel.org" <shuah@...nel.org>,
	"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
	"ij@...nel.org" <ij@...nel.org>, "ncardwell@...gle.com"
	<ncardwell@...gle.com>, "Koen De Schepper (Nokia)"
	<koen.de_schepper@...ia-bell-labs.com>, "g.white@...lelabs.com"
	<g.white@...lelabs.com>, "ingemar.s.johansson@...csson.com"
	<ingemar.s.johansson@...csson.com>, "mirja.kuehlewind@...csson.com"
	<mirja.kuehlewind@...csson.com>, "cheshire@...le.com" <cheshire@...le.com>,
	"rs.ietf@....at" <rs.ietf@....at>, "Jason_Livingood@...cast.com"
	<Jason_Livingood@...cast.com>, "vidhi_goel@...le.com" <vidhi_goel@...le.com>
Subject: RE: [PATCH v20 net-next 6/6] Documentation: netlink: specs: tc: Add
 DualPI2 specification

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org> 
> Sent: Saturday, June 28, 2025 1:20 AM
> To: Chia-Yu Chang (Nokia) <chia-yu.chang@...ia-bell-labs.com>
> Cc: alok.a.tiwari@...cle.com; pctammela@...atatu.com; horms@...nel.org; donald.hunter@...il.com; xandfury@...il.com; netdev@...r.kernel.org; dave.taht@...il.com; pabeni@...hat.com; jhs@...atatu.com; stephen@...workplumber.org; xiyou.wangcong@...il.com; jiri@...nulli.us; davem@...emloft.net; edumazet@...gle.com; andrew+netdev@...n.ch; ast@...erby.net; liuhangbin@...il.com; shuah@...nel.org; linux-kselftest@...r.kernel.org; ij@...nel.org; ncardwell@...gle.com; Koen De Schepper (Nokia) <koen.de_schepper@...ia-bell-labs.com>; g.white@...lelabs.com; ingemar.s.johansson@...csson.com; mirja.kuehlewind@...csson.com; cheshire@...le.com; rs.ietf@....at; Jason_Livingood@...cast.com; vidhi_goel@...le.com
> Subject: Re: [PATCH v20 net-next 6/6] Documentation: netlink: specs: tc: Add DualPI2 specification
> 
> 
> CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
> 
> 
> 
> On Sat, 21 Jun 2025 21:33:31 +0200 chia-yu.chang@...ia-bell-labs.com
> wrote:
> > From: Chia-Yu Chang <chia-yu.chang@...ia-bell-labs.com>
> >
> > Introduce the specification of tc qdisc DualPI2 stats and attributes, 
> > which is the reference implementation of IETF RFC9332 DualQ Coupled 
> > AQM
> > (https://datatracker.ietf.org/doc/html/rfc9332) providing two 
> > different
> > queues: low latency queue (L-queue) and classic queue (C-queue).
> 
> > diff --git a/Documentation/netlink/specs/tc.yaml 
> > b/Documentation/netlink/specs/tc.yaml
> > index 4cc1f6a45001..8a183799dceb 100644
> > --- a/Documentation/netlink/specs/tc.yaml
> > +++ b/Documentation/netlink/specs/tc.yaml
> > @@ -56,6 +56,41 @@ definitions:
[...]
> > +      -
> > +        name: step-thresh
> > +        type: u32
> > +        doc: L4S step marking threshold (see also step-packets)
> > +      -
> > +        name: step-packets
> > +        type: flag
> > +        doc: L4S Step marking threshold unit in packets
> > +             (otherwise is in microseconds)
> 
> Why mux two distinct values in one attr and carry another attr for the unit?
>
> IMO it'd be more idiomatic for Netlink to define two attributes, one for threshold in packets and one in time.
>
> And enforce that only one can be sent in a message (probably using an explicit check in the code).
>
> Conversely only report one in GET / DUMP.

Hi,

First, thanks for other comments, and I will do corresponding changes in the next version.

As for this comment, there are already two dualpi2 attribute of net-next and iproute2-next:

- "step_thresh" and "step_in_packets" in sch_dualpi2.c of net-next

- "TCA_DUALPI2_STEP_THRESH" and "TCA_DUALPI2_STEP_PACKETS" in q_dualpi2.c of iproute2-next

And the above two attributes in tc.yaml can therefore be mapped one-to-one.

I was thinking could we keep the same strucutre? As we already have several rounds of review for both net-next and iproute2-next.

Best regards,
Chia-Yu