netdev - Re: [RFC PATCH v2 0/6] net: wwan: add NMEA port type support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFEp6-08JX1gDDn2-hP5AjXHCGsPYHe05FscQoyiP_OaSQfzqQ@mail.gmail.com>
Date: Sun, 29 Jun 2025 04:50:18 +0200
From: Loic Poulain <loic.poulain@....qualcomm.com>
To: Sergey Ryazanov <ryazanov.s.a@...il.com>
Cc: Johannes Berg <johannes@...solutions.net>,
        Andrew Lunn <andrew+netdev@...n.ch>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
        netdev@...r.kernel.org, Slark Xiao <slark_xiao@....com>,
        Muhammad Nuzaihan <zaihan@...ealasia.net>,
        Qiang Yu <quic_qianyu@...cinc.com>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Johan Hovold <johan@...nel.org>
Subject: Re: [RFC PATCH v2 0/6] net: wwan: add NMEA port type support

Hi Sergey,

On Tue, Jun 24, 2025 at 11:39 PM Sergey Ryazanov <ryazanov.s.a@...il.com> wrote:
>
> The series introduces a long discussed NMEA port type support for the
> WWAN subsystem. There are two goals. From the WWAN driver perspective,
> NMEA exported as any other port type (e.g. AT, MBIM, QMI, etc.). From
> user space software perspective, the exported chardev belongs to the
> GNSS class what makes it easy to distinguish desired port and the WWAN
> device common to both NMEA and control (AT, MBIM, etc.) ports makes it
> easy to locate a control port for the GNSS receiver activation.
>
> Done by exporting the NMEA port via the GNSS subsystem with the WWAN
> core acting as proxy between the WWAN modem driver and the GNSS
> subsystem.
>
> The series starts from a cleanup patch. Then two patches prepares the
> WWAN core for the proxy style operation. Followed by a patch introding a
> new WWNA port type, integration with the GNSS subsystem and demux. The
> series ends with a couple of patches that introduce emulated EMEA port
> to the WWAN HW simulator.
>
> The series is the product of the discussion with Loic about the pros and
> cons of possible models and implementation. Also Muhammad and Slark did
> a great job defining the problem, sharing the code and pushing me to
> finish the implementation. Many thanks.
>
> Comments are welcomed.
>
> Slark, Muhammad, if this series suits you, feel free to bundle it with
> the driver changes and (re-)send for final inclusion as a single series.
>
> Changes RFCv1->RFCv2:
> * Uniformly use put_device() to release port memory. This made code less
>   weird and way more clear. Thank you, Loic, for noticing and the fix
>   discussion!

I think you can now send that series without the RFC tag. It looks good to me.