netdev - Re: [PATCH net-next v2] ptp: add Alibaba CIPU PTP clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aGKUThtBfPvlWL35@hoboy.vegasvil.org>
Date: Mon, 30 Jun 2025 06:42:38 -0700
From: Richard Cochran <richardcochran@...il.com>
To: Wen Gu <guwen@...ux.alibaba.com>
Cc: Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
	Andrew Lunn <andrew@...n.ch>, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, xuanzhuo@...ux.alibaba.com,
	dust.li@...ux.alibaba.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] ptp: add Alibaba CIPU PTP clock driver

On Mon, Jun 30, 2025 at 07:23:49PM +0800, Wen Gu wrote:

> In ptp_clock.c, ops.clock_settime() is assigned to ptp_clock_settime(),
> and it will call ptp->info->settime64() without checks. So I think these
> 'return -EOPNOTSUPP' functions are needed. Did I miss something?

Right, for the essential clock related callbacks, stubs are expected
by the ptp class layer.

Some of the newer, non-essential clock methods do indeed check the
function pointer, simply to accommodate existing drivers.

Thanks,
Richard