netdev - Re: [PATCH] net: stmmac: add support for dwmac 5.20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3e7fa26f-16b0-4564-80e8-4f2b5bcae3e9@linux.dev>
Date: Mon, 30 Jun 2025 10:16:20 +0800
From: Yanteng Si <si.yanteng@...ux.dev>
To: Andrew Lunn <andrew@...n.ch>, Jisheng Zhang <jszhang@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, Alexandre Torgue
 <alexandre.torgue@...s.st.com>, netdev@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: stmmac: add support for dwmac 5.20

在 6/30/25 2:26 AM, Andrew Lunn 写道:
> On Sun, Jun 29, 2025 at 05:44:25PM +0800, Jisheng Zhang wrote:
>> The dwmac 5.20 IP can be found on some synaptics SoCs. Add a
>> compatibility flag, and extend coverage of the dwmac-generic driver
>> for the 5.20 IP.
>>
>> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
>> ---
>>   drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
>> index b9218c07eb6b..cecce6ed9aa6 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
>> @@ -59,6 +59,7 @@ static const struct of_device_id dwmac_generic_match[] = {
>>   	{ .compatible = "snps,dwmac-3.72a"},
>>   	{ .compatible = "snps,dwmac-4.00"},
>>   	{ .compatible = "snps,dwmac-4.10a"},
>> +	{ .compatible = "snps,dwmac-5.20"},
>>   	{ .compatible = "snps,dwmac"},
>>   	{ .compatible = "snps,dwxgmac-2.10"},
>>   	{ .compatible = "snps,dwxgmac"},
> 
> I can see a compatible flag being added. But what about the extending
> the coverage of the dwmac-generic driver part?
I don't think the timing is ripe yet (including the patch itself).
Maybe it would be better to do this when a hardware driver is to
be introduced into the kernel.

Thanks,
Yanteng