From 02b643f4777c4c782271834c05a4f989379767a0 Mon Sep 17 00:00:00 2001 From: Victor Nogueira Date: Mon, 30 Jun 2025 17:27:44 +0000 Subject: [PATCH net-next] selftests/tc-testing: Fix test case 831d to reproduce UAF scenario Make test case 831d delete the HFSC class and then send packets so that it can reproduce the reported UAF scenario [1]. [1] https://lore.kernel.org/netdev/45876f14-cf28-4177-8ead-bb769fd9e57a@gmail.com/ Signed-off-by: Victor Nogueira --- .../tc-testing/tc-tests/infra/qdiscs.json | 35 +++++++++---------- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/tools/testing/selftests/tc-testing/tc-tests/infra/qdiscs.json b/tools/testing/selftests/tc-testing/tc-tests/infra/qdiscs.json index 9aa44d8176d9..0d3979334a4e 100644 --- a/tools/testing/selftests/tc-testing/tc-tests/infra/qdiscs.json +++ b/tools/testing/selftests/tc-testing/tc-tests/infra/qdiscs.json @@ -580,26 +580,23 @@ "category": ["qdisc", "hfsc", "drr", "netem", "blackhole"], "plugins": { "requires": ["nsPlugin", "scapyPlugin"] }, "setup": [ - "$IP link set dev $DEV1 up || true", - "$TC qdisc add dev $DEV1 root handle 1: drr", - "$TC filter add dev $DEV1 parent 1: basic classid 1:1", - "$TC class add dev $DEV1 parent 1: classid 1:1 drr", - "$TC qdisc add dev $DEV1 parent 1:1 handle 2: hfsc def 1", - "$TC class add dev $DEV1 parent 2: classid 2:1 hfsc rt m1 8 d 1 m2 0", - "$TC qdisc add dev $DEV1 parent 2:1 handle 3: netem", - "$TC qdisc add dev $DEV1 parent 3:1 handle 4: blackhole" + "$IP link set dev $DUMMY up || true", + "$IP addr add 10.10.11.10/24 dev $DUMMY || true", + "$TC qdisc add dev $DUMMY root handle 1: drr", + "$TC filter add dev $DUMMY parent 1: basic classid 1:1", + "$TC class add dev $DUMMY parent 1: classid 1:1 drr", + "$TC qdisc add dev $DUMMY parent 1:1 handle 2: hfsc def 1", + "$TC class add dev $DUMMY parent 2: classid 2:1 hfsc rt m1 8 d 1 m2 0", + "$TC qdisc add dev $DUMMY parent 2:1 handle 3: netem", + "$TC qdisc add dev $DUMMY parent 3:1 handle 4: blackhole", + "ping -c1 -W0.01 -I $DUMMY 10.10.11.11 || true", + "$TC class del dev $DUMMY classid 1:1" ], - "scapy": { - "iface": "$DEV0", - "count": 5, - "packet": "Ether()/IP(dst='10.10.10.1', src='10.10.10.10')/ICMP()" - }, - "cmdUnderTest": "$TC -s qdisc show dev $DEV1", - "expExitCode": "0", - "verifyCmd": "$TC -s qdisc show dev $DEV1", - "matchPattern": "qdisc hfsc", - "matchCount": "1", - "teardown": ["$TC qdisc del dev $DEV1 root handle 1: drr"] + "cmdUnderTest": "ping -c1 -W0.01 -I $DUMMY 10.10.11.11", + "expExitCode": "1", + "verifyCmd": "$TC -j class ls dev $DUMMY classid 1:1", + "matchJSON": [], + "teardown": ["$TC qdisc del dev $DUMMY root handle 1: drr"] }, { "id": "309e", -- 2.34.1