netdev - Re: [PATCH] net: dsa: hellcreek: Constify struct devlink_region_ops and struct hellcreek_fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8734bhyng4.fsf@kurt.kurt.home>
Date: Mon, 30 Jun 2025 22:38:35 +0200
From: Kurt Kanzenbach <kurt@...utronix.de>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, Andrew Lunn
 <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Richard Cochran
 <richardcochran@...il.com>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 Christophe JAILLET <christophe.jaillet@...adoo.fr>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: dsa: hellcreek: Constify struct devlink_region_ops
 and struct hellcreek_fdb_entry

On Sun Jun 29 2025, Christophe JAILLET wrote:
> 'struct devlink_region_ops' and 'struct hellcreek_fdb_entry' are not
> modified in this driver.
>
> Constifying these structures moves some data to a read-only section, so
> increases overall security, especially when the structure holds some
> function pointers.
>
> On a x86_64, with allmodconfig:
> Before:
> ======
>    text	   data	    bss	    dec	    hex	filename
>   55320	  19216	    320	  74856	  12468	drivers/net/dsa/hirschmann/hellcreek.o
>
> After:
> =====
>    text	   data	    bss	    dec	    hex	filename
>   55960	  18576	    320	  74856	  12468	drivers/net/dsa/hirschmann/hellcreek.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Kurt Kanzenbach <kurt@...utronix.de>

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)