netdev - Re: [RFC] net: openvswitch: Inroduce a light-weight socket map concept.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iK0C+cmhPsikuAztBjppkr6W1NF3mFn0Rh1Npb+yDgzHQ@mail.gmail.com>
Date: Mon, 30 Jun 2025 03:07:54 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: Aaron Conole <aconole@...hat.com>, dev@...nvswitch.org, netdev@...r.kernel.org, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Eelco Chaudron <echaudro@...hat.com>, Ilya Maximets <i.maximets@....org>, 
	Adrián Moreno <amorenoz@...hat.com>, 
	Mike Pattrick <mpattric@...hat.com>, Florian Westphal <fw@...len.de>, 
	John Fastabend <john.fastabend@...il.com>, Jakub Sitnicki <jakub@...udflare.com>, 
	Joe Stringer <joe@....org>
Subject: Re: [RFC] net: openvswitch: Inroduce a light-weight socket map concept.

On Fri, Jun 27, 2025 at 2:55 PM Stephen Hemminger
<stephen@...workplumber.org> wrote:
>
> On Fri, 27 Jun 2025 17:00:54 -0400
> Aaron Conole <aconole@...hat.com> wrote:
>
> > diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
> > index 429fb34b075e..f43f905b1cb0 100644
> > --- a/net/ipv4/tcp_ipv4.c
> > +++ b/net/ipv4/tcp_ipv4.c
> > @@ -93,6 +93,7 @@ static int tcp_v4_md5_hash_hdr(char *md5_hash, const struct tcp_md5sig_key *key,
> >  #endif
> >
> >  struct inet_hashinfo tcp_hashinfo;
> > +EXPORT_SYMBOL(tcp_hashinfo);
>
> EXPORT_SYMBOL_GPL seems better here

Even better, not use tcp_hashinfo at all, it will break for netns
having private hash tables.

Instead use :

struct inet_hashinfo *hinfo = net->ipv4.tcp_death_row.hashinfo