netdev - Re: [patch 3/3] ptp: Enable auxiliary clocks for PTP_SYS_OFFSET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tt3wkquv.ffs@tglx>
Date: Tue, 01 Jul 2025 15:00:56 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: LKML <linux-kernel@...r.kernel.org>
Cc: netdev@...r.kernel.org, Richard Cochran <richardcochran@...il.com>,
 Christopher Hall <christopher.s.hall@...el.com>, John Stultz
 <jstultz@...gle.com>, Frederic Weisbecker <frederic@...nel.org>,
 Anna-Maria Behnsen <anna-maria@...utronix.de>, Miroslav Lichvar
 <mlichvar@...hat.com>, Werner Abt <werner.abt@...nberg-usa.com>, David
 Woodhouse <dwmw2@...radead.org>, Stephen Boyd <sboyd@...nel.org>, Thomas
 Weißschuh <thomas.weissschuh@...utronix.de>, Kurt
 Kanzenbach
 <kurt@...utronix.de>, Nam Cao <namcao@...utronix.de>, Antoine Tenart
 <atenart@...nel.org>
Subject: Re: [patch 3/3] ptp: Enable auxiliary clocks for
 PTP_SYS_OFFSET_EXTENDED

On Thu, Jun 26 2025 at 15:27, Thomas Gleixner wrote:
> +	switch (extoff->clockid) {
> +	case CLOCK_REALTIME:
> +	case CLOCK_MONOTONIC:
> +	case CLOCK_MONOTONIC_RAW:
> +	case CLOCK_AUX ... CLOCK_AUX_LAST:
> +		break;

While trying to solve the merge logistics problem I noticed that this
should be:

	switch (extoff->clockid) {
	case CLOCK_REALTIME:
	case CLOCK_MONOTONIC:
	case CLOCK_MONOTONIC_RAW:
        	break;
	case CLOCK_AUX ... CLOCK_AUX_LAST:
        	if (IS_ENABLED(CONFIG_POSIX_AUX_CLOCKS))
			break;
		fallthrough;

obviously as there is no point in going all the way down into the time
stamping code to figure out that this is disabled.

I blame it all on the heat wave of course :)