netdev - Re: [PATCH v2 net-next] net: atlantic: Rename PCI driver struct to end in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250701132948.GS41770@horms.kernel.org>
Date: Tue, 1 Jul 2025 14:29:48 +0100
From: Simon Horman <horms@...nel.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Igor Russkikh <irusskikh@...vell.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Alexander Loktionov <Alexander.Loktionov@...antia.com>,
	David VomLehn <vomlehn@...as.net>,
	Dmitry Bezrukov <Dmitry.Bezrukov@...antia.com>,
	Pavel Belous <Pavel.Belous@...antia.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] net: atlantic: Rename PCI driver struct to
 end in _driver

On Mon, Jun 30, 2025 at 06:44:07PM +0200, Uwe Kleine-König wrote:
> This is not only a cosmetic change because the section mismatch checks
> (implemented in scripts/mod/modpost.c) also depend on the object's name
> and for drivers the checks are stricter than for ops.
> 
> However aq_pci_driver also passes the stricter checks just fine, so no
> further changes needed.
> 
> The cheating^Wmisleading name was introduced in commit 97bde5c4f909
> ("net: ethernet: aquantia: Support for NIC-specific code")
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> ---
> Changes since implicit v1 (available at
> https://lore.kernel.org/netdev/20250627094642.1923993-2-u.kleine-koenig@baylibre.com):
> 
>  - Improve commit log to explain in more detail the check
>  - Mention the introducing commit in prose and not in a Fixes: line
>  - trivially rebase to a newer next tag
>  - explicitly mark for net-next in the Subject line

Thanks for your patience and making these updates.

Reviewed-by: Simon Horman <horms@...nel.org>