netdev - Re: [PATCH net] dt-bindings: net: sophgo,sg2044-dwmac: Drop status from the example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b986b184f2a29bb549daeff5c84547d64341f796.camel@gmail.com>
Date: Tue, 01 Jul 2025 16:13:06 +0200
From: Alexander Sverdlin <alexander.sverdlin@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Andrew Lunn	
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet	 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni	 <pabeni@...hat.com>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski	 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Chen
 Wang	 <unicorn_wang@...look.com>, Inochi Amaoto <inochiama@...il.com>, 
	netdev@...r.kernel.org, devicetree@...r.kernel.org, sophgo@...ts.linux.dev,
 	linux-kernel@...r.kernel.org
Cc: stable@...r.kernel.org
Subject: Re: [PATCH net] dt-bindings: net: sophgo,sg2044-dwmac: Drop status
 from the example

On Tue, 2025-07-01 at 08:36 +0200, Krzysztof Kozlowski wrote:
> Examples should be complete and should not have a 'status' property,
> especially a disabled one because this disables the dt_binding_check of
> the example against the schema.  Dropping 'status' property shows
> missing other properties - phy-mode and phy-handle.
> 
> Fixes: 114508a89ddc ("dt-bindings: net: Add support for Sophgo SG2044 dwmac")
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...il.com>

> ---
>  Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml b/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml
> index 4dd2dc9c678b..8afbd9ebd73f 100644
> --- a/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml
> @@ -80,6 +80,8 @@ examples:
>        interrupt-parent = <&intc>;
>        interrupts = <296 IRQ_TYPE_LEVEL_HIGH>;
>        interrupt-names = "macirq";
> +      phy-handle = <&phy0>;
> +      phy-mode = "rgmii-id";
>        resets = <&rst 30>;
>        reset-names = "stmmaceth";
>        snps,multicast-filter-bins = <0>;
> @@ -91,7 +93,6 @@ examples:
>        snps,mtl-rx-config = <&gmac0_mtl_rx_setup>;
>        snps,mtl-tx-config = <&gmac0_mtl_tx_setup>;
>        snps,axi-config = <&gmac0_stmmac_axi_setup>;
> -      status = "disabled";
>  
>        gmac0_mtl_rx_setup: rx-queues-config {
>          snps,rx-queues-to-use = <8>;

-- 
Alexander Sverdlin.