netdev - Re: [PATCH net v2] net: ipv4: fix stat increase when udp early demux drops the packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGPxoZsW8_qa5gyF@krikkit>
Date: Tue, 1 Jul 2025 16:33:05 +0200
From: Sabrina Dubroca <sd@...asysnail.net>
To: Antoine Tenart <atenart@...nel.org>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	edumazet@...gle.com, netdev@...r.kernel.org,
	Menglong Dong <menglong8.dong@...il.com>
Subject: Re: [PATCH net v2] net: ipv4: fix stat increase when udp early demux
 drops the packet

2025-07-01, 09:49:34 +0200, Antoine Tenart wrote:
> udp_v4_early_demux now returns drop reasons as it either returns 0 or
> ip_mc_validate_source, which returns itself a drop reason. However its
> use was not converted in ip_rcv_finish_core and the drop reason is
> ignored, leading to potentially skipping increasing LINUX_MIB_IPRPFILTER
> if the drop reason is SKB_DROP_REASON_IP_RPFILTER.
> 
> This is a fix and we're not converting udp_v4_early_demux to explicitly
> return a drop reason to ease backports; this can be done as a follow-up.
> 
> Fixes: d46f827016d8 ("net: ip: make ip_mc_validate_source() return drop reason")
> Cc: Menglong Dong <menglong8.dong@...il.com>
> Reported-by: Sabrina Dubroca <sd@...asysnail.net>
> Signed-off-by: Antoine Tenart <atenart@...nel.org>
> ---
> Changes in v2:
>   - Reset the drop reason to NOT_SPECIFIED if not returning early. The
>     diff remains small and this aligns with the rest of the function.
> ---
>  net/ipv4/ip_input.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Reviewed-by: Sabrina Dubroca <sd@...asysnail.net>

Thanks Antoine.

-- 
Sabrina