netdev - Re: [PATCH v17 09/22] sfc: create type2 cxl memdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09e46b72-7142-41ef-b0e6-c3883879cc8d@amd.com>
Date: Tue, 1 Jul 2025 16:30:02 +0100
From: Alejandro Lucero Palau <alucerop@....com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 alejandro.lucero-palau@....com
Cc: linux-cxl@...r.kernel.org, netdev@...r.kernel.org,
 dan.j.williams@...el.com, edward.cree@....com, davem@...emloft.net,
 kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
 dave.jiang@...el.com, Martin Habets <habetsm.xilinx@...il.com>,
 Fan Ni <fan.ni@...sung.com>, Edward Cree <ecree.xilinx@...il.com>
Subject: Re: [PATCH v17 09/22] sfc: create type2 cxl memdev


On 6/27/25 09:51, Jonathan Cameron wrote:
> On Tue, 24 Jun 2025 15:13:42 +0100
> <alejandro.lucero-palau@....com> wrote:
>
>> From: Alejandro Lucero <alucerop@....com>
>>
>> Use cxl API for creating a cxl memory device using the type2
>> cxl_dev_state struct.
>>
>> Signed-off-by: Alejandro Lucero <alucerop@....com>
>> Reviewed-by: Martin Habets <habetsm.xilinx@...il.com>
>> Reviewed-by: Fan Ni <fan.ni@...sung.com>
>> Acked-by: Edward Cree <ecree.xilinx@...il.com>
>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>> ---
>>   drivers/net/ethernet/sfc/efx_cxl.c | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/sfc/efx_cxl.c b/drivers/net/ethernet/sfc/efx_cxl.c
>> index 5d68ee4e818d..e2d52ed49535 100644
>> --- a/drivers/net/ethernet/sfc/efx_cxl.c
>> +++ b/drivers/net/ethernet/sfc/efx_cxl.c
>> @@ -79,6 +79,13 @@ int efx_cxl_init(struct efx_probe_data *probe_data)
>>   
>>   	cxl_set_capacity(&cxl->cxlds, EFX_CTPIO_BUFFER_SIZE);
>>   
>> +	cxl->cxlmd = devm_cxl_add_memdev(&pci_dev->dev, &cxl->cxlds);
>> +
> Trivial style thing but common practice (I haven't checked local style)
> is no blank line between call and associated error check.


Right. I'll fix it.

Thanks


>> +	if (IS_ERR(cxl->cxlmd)) {
>> +		pci_err(pci_dev, "CXL accel memdev creation failed");
>> +		return PTR_ERR(cxl->cxlmd);
>> +	}
>> +
>>   	probe_data->cxl = cxl;
>>   
>>   	return 0;