netdev - Re: [PATCH bpf-next 02/13] bpf: Helpers for skb dynptr read/write/slice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507011044.vjYugeUq-lkp@intel.com>
Date: Tue, 1 Jul 2025 11:06:46 +0800
From: kernel test robot <lkp@...el.com>
To: Jakub Sitnicki <jakub@...udflare.com>, bpf@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Alexei Starovoitov <ast@...nel.org>,
	Arthur Fabre <arthur@...hurfabre.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Jesper Dangaard Brouer <hawk@...nel.org>,
	Jesse Brandeburg <jbrandeburg@...udflare.com>,
	Joanne Koong <joannelkoong@...il.com>,
	Lorenzo Bianconi <lorenzo@...nel.org>,
	Toke Høiland-Jørgensen <thoiland@...hat.com>,
	Yan Zhai <yan@...udflare.com>, netdev@...r.kernel.org,
	kernel-team@...udflare.com, Stanislav Fomichev <sdf@...ichev.me>
Subject: Re: [PATCH bpf-next 02/13] bpf: Helpers for skb dynptr
 read/write/slice

Hi Jakub,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Jakub-Sitnicki/bpf-Ignore-dynptr-offset-in-skb-data-access/20250630-225941
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link:    https://lore.kernel.org/r/20250630-skb-metadata-thru-dynptr-v1-2-f17da13625d8%40cloudflare.com
patch subject: [PATCH bpf-next 02/13] bpf: Helpers for skb dynptr read/write/slice
config: i386-buildonly-randconfig-002-20250701 (https://download.01.org/0day-ci/archive/20250701/202507011044.vjYugeUq-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250701/202507011044.vjYugeUq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507011044.vjYugeUq-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from kernel/bpf/helpers.c:15:
   include/linux/filter.h:1788:1: error: expected identifier or '(' before '{' token
    1788 | {
         | ^
   include/linux/filter.h:1795:1: error: expected identifier or '(' before '{' token
    1795 | {
         | ^
   kernel/bpf/helpers.c: In function '____bpf_snprintf':
   kernel/bpf/helpers.c:1068:9: warning: function '____bpf_snprintf' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
    1068 |         err = bstr_printf(str, str_size, fmt, data.bin_args);
         |         ^~~
   include/linux/filter.h: At top level:
>> include/linux/filter.h:1785:19: warning: 'bpf_dynptr_skb_write' used but never defined
    1785 | static inline int bpf_dynptr_skb_write(const struct bpf_dynptr_kern *dst,
         |                   ^~~~~~~~~~~~~~~~~~~~
>> include/linux/filter.h:1792:21: warning: 'bpf_dynptr_skb_slice' used but never defined
    1792 | static inline void *bpf_dynptr_skb_slice(const struct bpf_dynptr_kern *ptr,
         |                     ^~~~~~~~~~~~~~~~~~~~


vim +/bpf_dynptr_skb_write +1785 include/linux/filter.h

  1784	
> 1785	static inline int bpf_dynptr_skb_write(const struct bpf_dynptr_kern *dst,
  1786					       u32 offset, const void *src, u32 len,
  1787					       u64 flags);
  1788	{
  1789		return -EOPNOTSUPP;
  1790	}
  1791	
> 1792	static inline void *bpf_dynptr_skb_slice(const struct bpf_dynptr_kern *ptr,
  1793						 u32 offset, void *buf, u32 len);
  1794	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki