netdev - RE: [PATCH] net: libwx: fix the incorrect display of the queue number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <050201dbea56$0f357410$2da05c30$@trustnetic.com>
Date: Tue, 1 Jul 2025 15:02:07 +0800
From: Jiawen Wu <jiawenwu@...stnetic.com>
To: "'Jakub Kicinski'" <kuba@...nel.org>
Cc: <netdev@...r.kernel.org>,
	<andrew+netdev@...n.ch>,
	<davem@...emloft.net>,
	<edumazet@...gle.com>,
	<pabeni@...hat.com>,
	<horms@...nel.org>,
	<mengyuanlou@...-swift.com>,
	<stable@...r.kernel.org>
Subject: RE: [PATCH] net: libwx: fix the incorrect display of the queue number

On Tue, Jul 1, 2025 9:31 AM, Jakub Kicinski wrote:
> On Fri, 27 Jun 2025 16:09:38 +0800 Jiawen Wu wrote:
> > When setting "ethtool -L eth0 combined 1", the number of RX/TX queue is
> > changed to be 1. RSS is disabled at this moment, and the indices of FDIR
> > have not be changed in wx_set_rss_queues(). So the combined count still
> > shows the previous value. This issue was introduced when supporting
> > FDIR. Fix it for those devices that support FDIR.
> 
> Why are you hacking up the get_channels rather than making _F_FDIR be
> sane in all situations? I mean why not:
> 
> --- a/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> +++ b/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> @@ -1709,6 +1709,7 @@ static void wx_set_rss_queues(struct wx *wx)
>          * distribution of flows across cores, even when an FDIR flow
>          * isn't matched.
>          */
> +       wx->ring_feature[RING_F_FDIR].indices = 1;
>         if (f->indices > 1) {
>                 f = &wx->ring_feature[RING_F_FDIR];
> 
> ?

This is quite reasonable, thanks.