netdev - Re: [PATCH net-next v4 12/14] net: mctp: allow NL parsing directly into a struct mctp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d59148bad48ac9296ca67fcbffa4076630ba8f63.camel@codeconstruct.com.au>
Date: Wed, 02 Jul 2025 13:28:35 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: Paolo Abeni <pabeni@...hat.com>, Matt Johnston
 <matt@...econstruct.com.au>,  "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Simon
 Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next v4 12/14] net: mctp: allow NL parsing directly
 into a struct mctp_route

Hi Paolo,

> > -       if (dev->flags & IFF_LOOPBACK) {
> > -               NL_SET_ERR_MSG(extack, "no routes to loopback");
> > -               return -EINVAL;
> > -       }
> 
> It looks like the above test is not performed anymore. Is that
> intentional?

No, not intentional - this was removed from the parsing code, but not
reinstated in the route handling side. I have added it back, v5 coming
shortly.

Cheers,

Jeremy