netdev - Re: [PATCH net-next] net: ethtool: fix leaking netdev ref if ethnl_default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <175141741881.160580.14789268644696405027.git-patchwork-notify@kernel.org>
Date: Wed, 02 Jul 2025 00:50:18 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, idosch@...sch.org, netdev@...r.kernel.org,
 edumazet@...gle.com, pabeni@...hat.com, andrew+netdev@...n.ch,
 horms@...nel.org
Subject: Re: [PATCH net-next] net: ethtool: fix leaking netdev ref if
 ethnl_default_parse() failed

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Mon, 30 Jun 2025 08:40:53 -0700 you wrote:
> Ido spotted that I made a mistake in commit under Fixes,
> ethnl_default_parse() may acquire a dev reference even when it returns
> an error. This may have been driven by the code structure in dumps
> (which unconditionally release dev before handling errors), but it's
> too much of a trap. Functions should undo what they did before returning
> an error, rather than expecting caller to clean up.
> 
> [...]

Here is the summary with links:
  - [net-next] net: ethtool: fix leaking netdev ref if ethnl_default_parse() failed
    https://git.kernel.org/netdev/net-next/c/3249eae7e445

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html