netdev - Re: [PATCH net] bnxt_en: eliminate the compile warning in bnxt_request_irq due to CONFIG_RFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250701175607.35f2a544@kernel.org>
Date: Tue, 1 Jul 2025 17:56:07 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jason Xing <kerneljasonxing@...il.com>
Cc: Simon Horman <horms@...nel.org>, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, andrew+netdev@...n.ch,
 michael.chan@...adcom.com, pavan.chebbi@...adcom.com,
 netdev@...r.kernel.org, Jason Xing <kernelxing@...cent.com>, kernel test
 robot <lkp@...el.com>
Subject: Re: [PATCH net] bnxt_en: eliminate the compile warning in
 bnxt_request_irq due to CONFIG_RFS_ACCEL

On Wed, 2 Jul 2025 08:47:08 +0800 Jason Xing wrote:
> >  static int bnxt_request_irq(struct bnxt *bp)
> >  {
> > +       struct cpu_rmap *rmap = NULL;
> >         int i, j, rc = 0;
> >         unsigned long flags = 0;
> > -#ifdef CONFIG_RFS_ACCEL
> > -       struct cpu_rmap *rmap;
> > -#endif  
> 
> Sorry, Jakub. I failed to see the positive point of this kind of
> change comparatively.

Like Simon said -- fewer #ifdefs leads to fewer bugs of this nature.
Or do you mean that you don't understand how my fix works?

> >         rc = bnxt_setup_int_mode(bp);
> >         if (rc) {  
> 
> Probably in this position, you expect 'rmap = bp->dev->rx_cpu_rmap;'
> to stay there even when CONFIG_RFS_ACCEL is off?

no, dev->rx_cpu_rmap doesn't exist if RDS_ACCEL=n

> The report says it's 'j' that causes the complaint.