netdev - Re: [PATCH net v3] amd-xgbe: do not double read link status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250702123847.GD41770@horms.kernel.org>
Date: Wed, 2 Jul 2025 13:38:47 +0100
From: Simon Horman <horms@...nel.org>
To: Raju Rangoju <Raju.Rangoju@....com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	Shyam-sundar.S-k@....com
Subject: Re: [PATCH net v3] amd-xgbe: do not double read link status

On Tue, Jul 01, 2025 at 12:20:16PM +0530, Raju Rangoju wrote:
> The link status is latched low so that momentary link drops
> can be detected. Always double-reading the status defeats this
> design feature. Only double read if link was already down
> 
> This prevents unnecessary duplicate readings of the link status.
> 
> Fixes: 4f3b20bfbb75 ("amd-xgbe: add support for rx-adaptation")
> Signed-off-by: Raju Rangoju <Raju.Rangoju@....com>
> ---
> Changes since v2:
> - update the commit message
> - avoid using gotos for normal function control flow
> 
> Changes since v1:
> - skip double-read to detect short link drops
> - refine the subject line for clarity

Thanks for the updates.
I agree this addresses Jakub's review of v2.

Reviewed-by: Simon Horman <horms@...nel.org>