netdev - Re: [PATCH net-next 1/4] ibmvnic: Derive NUM_RX_STATS/NUM_TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250701183016.26212cec@kernel.org>
Date: Tue, 1 Jul 2025 18:30:16 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Mingming Cao <mmc@...ux.ibm.com>
Cc: netdev@...r.kernel.org, bjking1@...ux.ibm.com, haren@...ux.ibm.com,
 ricklind@...ux.ibm.com, Dave Marquardt <davemarq@...ux.ibm.com>
Subject: Re: [PATCH net-next 1/4] ibmvnic: Derive NUM_RX_STATS/NUM_TX_STATS
 dynamically

On Mon, 30 Jun 2025 16:48:03 -0700 Mingming Cao wrote:
> Replace the hardcoded #define NUM_RX_STATS/NUM_TX_STATS 3
> with a sizeof-based calculation to automatically reflect
> the number of fields in struct ibmvnic_rx_queue_stats.
> and struct ibmvnic_tx_queue_stats.
> 
> This avoids mismatches and improves maintainability.
> 
> Fixes: 2ee73c54a615 ("ibmvnic: Add stat for tx direct vs tx batched")

Fixes tags are for changes which fix user-visible bugs. Please remove