[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aGVR2YqVLaWykAfV@mini-arch>
Date: Wed, 2 Jul 2025 08:35:53 -0700
From: Stanislav Fomichev <stfomichev@...il.com>
To: Jason Xing <kerneljasonxing@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, bjorn@...nel.org, magnus.karlsson@...el.com,
maciej.fijalkowski@...el.com, jonathan.lemon@...il.com,
sdf@...ichev.me, ast@...nel.org, daniel@...earbox.net,
hawk@...nel.org, john.fastabend@...il.com, joe@...a.to,
willemdebruijn.kernel@...il.com, bpf@...r.kernel.org,
netdev@...r.kernel.org, Jason Xing <kernelxing@...cent.com>
Subject: Re: [PATCH net-next v2] Documentation: xsk: correct the obsolete
references and examples
On 07/02, Jason Xing wrote:
> From: Jason Xing <kernelxing@...cent.com>
>
> The modified lines are mainly related to the following commits[1][2]
> which remove those tests and examples. Since samples/bpf has been
> deprecated, we can refer to more examples that are easily searched
> in the various xdp-projects, like the following link:
> https://github.com/xdp-project/bpf-examples/tree/main/AF_XDP-example
>
> [1]
> commit f36600634282 ("libbpf: move xsk.{c,h} into selftests/bpf")
> [2]
> commit cfb5a2dbf141 ("bpf, samples: Remove AF_XDP samples")
>
> Signed-off-by: Jason Xing <kernelxing@...cent.com>
> ---
> V2
> Link: https://lore.kernel.org/all/20250628120841.12421-1-kerneljasonxing@gmail.com/
> 1. restore one part of doc and keep modifying a bit.
> ---
> Documentation/networking/af_xdp.rst | 39 +++++++++++++----------------
> 1 file changed, 18 insertions(+), 21 deletions(-)
>
> diff --git a/Documentation/networking/af_xdp.rst b/Documentation/networking/af_xdp.rst
> index dceeb0d763aa..a206c3636468 100644
> --- a/Documentation/networking/af_xdp.rst
> +++ b/Documentation/networking/af_xdp.rst
> @@ -209,13 +209,10 @@ Libbpf
>
> Libbpf is a helper library for eBPF and XDP that makes using these
> technologies a lot simpler. It also contains specific helper functions
> -in tools/lib/bpf/xsk.h for facilitating the use of AF_XDP. It
> -contains two types of functions: those that can be used to make the
> -setup of AF_XDP socket easier and ones that can be used in the data
> -plane to access the rings safely and quickly. To see an example on how
> -to use this API, please take a look at the sample application in
> -samples/bpf/xdpsock_usr.c which uses libbpf for both setup and data
> -plane operations.
> +in ./tools/testing/selftests/bpf/xsk.h for facilitating the use of
nit: the paths are always relative from the git root,
maybe drop ./ from ./tools?
Acked-by: Stanislav Fomichev <sdf@...ichev.me>
Powered by blists - more mailing lists