netdev - Re: [PATCH net-next 3/5] eth: mlx5: migrate to the *_rxfh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250701194309.1dcb7467@kernel.org>
Date: Tue, 1 Jul 2025 19:43:09 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Gal Pressman <gal@...dia.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, andrew@...n.ch,
 przemyslaw.kitszel@...el.com, anthony.l.nguyen@...el.com,
 sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com,
 bbhushan2@...vell.com, tariqt@...dia.com, mbloch@...dia.com,
 leon@...nel.org, ecree.xilinx@...il.com
Subject: Re: [PATCH net-next 3/5] eth: mlx5: migrate to the *_rxfh_context
 ops

On Tue, 1 Jul 2025 09:25:41 +0300 Gal Pressman wrote:
> > +	mlx5e_rx_res_rss_get_rxfh(priv->rx_res, rxfh->rss_context,
> > +				  ethtool_rxfh_context_indir(ctx),
> > +				  ethtool_rxfh_context_key(ctx),
> > +				  &ctx->hfunc, &symmetric);  
> 
> We don't expect it to fail so no return value check here, but maybe a
> WARN_ON_ONCE() should be added?

Hm.. you know what, I think I'll pop that WARN_ON_ONCE() inside
mlx5e_rx_res_rss_get_rxfh() and make it return void. Core doesn't
call get_rxfh for custom contexts any more, the only calls to
mlx5e_rx_res_rss_get_rxfh() are this one right after creation
and the one that asks for context 0, which I suppose must always exist.