netdev - Re: [PATCH ipsec] xfrm: Set transport header to fix UDP GRO handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aGY9WTUYVEYH0Sc6@gauss3.secunet.de>
Date: Thu, 3 Jul 2025 10:20:41 +0200
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Tobias Brunner <tobias@...ongswan.org>
CC: Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller"
	<davem@...emloft.net>, <netdev@...r.kernel.org>, <devel@...ux-ipsec.org>
Subject: Re: [PATCH ipsec] xfrm: Set transport header to fix UDP GRO handling

On Tue, Jun 24, 2025 at 02:47:20PM +0200, Tobias Brunner wrote:
> The referenced commit replaced a call to __xfrm4|6_udp_encap_rcv() with
> a custom check for non-ESP markers.  But what the called function also
> did was setting the transport header to the ESP header.  The function
> that follows, esp4|6_gro_receive(), relies on that being set when it calls
> xfrm_parse_spi().  We have to set the full offset as the skb's head was
> not moved yet so adding just the UDP header length won't work.
> 
> Fixes: e3fd05777685 ("xfrm: Fix UDP GRO handling for some corner cases")
> Signed-off-by: Tobias Brunner <tobias@...ongswan.org>

Applied, thanks Tobias!