netdev - Re: [Intel-wired-lan] [iwl-next] ixgbe: add the 2.5G and 5G speed in auto-negotiation for E610

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4290ec59-645d-4675-9c98-f59246796f3c@molgen.mpg.de>
Date: Thu, 3 Jul 2025 16:00:34 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Piotr Kwapulinski <piotr.kwapulinski@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org, andrew@...n.ch,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>
Subject: Re: [Intel-wired-lan] [iwl-next] ixgbe: add the 2.5G and 5G speed in
 auto-negotiation for E610

Dear Piotr,


Thank you for your patch.

Am 03.07.25 um 16:09 schrieb Piotr Kwapulinski:
> Enable the 2.5G and 5G speed in auto-negotiation for E610 at driver load.

The removed comment says there were incompatibilities with “certain 
switches“. What changed? Please elaborate in the commit message.


Kind regards,

Paul


> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Piotr Kwapulinski <piotr.kwapulinski@...el.com>
> ---
>   drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 35 +++++++------------
>   1 file changed, 12 insertions(+), 23 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> index d741164..b202639 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> @@ -1953,6 +1953,16 @@ int ixgbe_identify_phy_e610(struct ixgbe_hw *hw)
>   	    phy_type_low  & IXGBE_PHY_TYPE_LOW_1G_SGMII    ||
>   	    phy_type_high & IXGBE_PHY_TYPE_HIGH_1G_USXGMII)
>   		hw->phy.speeds_supported |= IXGBE_LINK_SPEED_1GB_FULL;
> +	if (phy_type_low  & IXGBE_PHY_TYPE_LOW_2500BASE_T   ||
> +	    phy_type_low  & IXGBE_PHY_TYPE_LOW_2500BASE_X   ||
> +	    phy_type_low  & IXGBE_PHY_TYPE_LOW_2500BASE_KX  ||
> +	    phy_type_high & IXGBE_PHY_TYPE_HIGH_2500M_SGMII ||
> +	    phy_type_high & IXGBE_PHY_TYPE_HIGH_2500M_USXGMII)
> +		hw->phy.speeds_supported |= IXGBE_LINK_SPEED_2_5GB_FULL;
> +	if (phy_type_low  & IXGBE_PHY_TYPE_LOW_5GBASE_T  ||
> +	    phy_type_low  & IXGBE_PHY_TYPE_LOW_5GBASE_KR ||
> +	    phy_type_high & IXGBE_PHY_TYPE_HIGH_5G_USXGMII)
> +		hw->phy.speeds_supported |= IXGBE_LINK_SPEED_5GB_FULL;
>   	if (phy_type_low  & IXGBE_PHY_TYPE_LOW_10GBASE_T       ||
>   	    phy_type_low  & IXGBE_PHY_TYPE_LOW_10G_SFI_DA      ||
>   	    phy_type_low  & IXGBE_PHY_TYPE_LOW_10GBASE_SR      ||
> @@ -1963,31 +1973,10 @@ int ixgbe_identify_phy_e610(struct ixgbe_hw *hw)
>   	    phy_type_high & IXGBE_PHY_TYPE_HIGH_10G_USXGMII)
>   		hw->phy.speeds_supported |= IXGBE_LINK_SPEED_10GB_FULL;
>   
> -	/* 2.5 and 5 Gbps link speeds must be excluded from the
> -	 * auto-negotiation set used during driver initialization due to
> -	 * compatibility issues with certain switches. Those issues do not
> -	 * exist in case of E610 2.5G SKU device (0x57b1).
> -	 */
> -	if (!hw->phy.autoneg_advertised &&
> -	    hw->device_id != IXGBE_DEV_ID_E610_2_5G_T)
> +	/* Initialize autoneg speeds */
> +	if (!hw->phy.autoneg_advertised)
>   		hw->phy.autoneg_advertised = hw->phy.speeds_supported;
>   
> -	if (phy_type_low  & IXGBE_PHY_TYPE_LOW_2500BASE_T   ||
> -	    phy_type_low  & IXGBE_PHY_TYPE_LOW_2500BASE_X   ||
> -	    phy_type_low  & IXGBE_PHY_TYPE_LOW_2500BASE_KX  ||
> -	    phy_type_high & IXGBE_PHY_TYPE_HIGH_2500M_SGMII ||
> -	    phy_type_high & IXGBE_PHY_TYPE_HIGH_2500M_USXGMII)
> -		hw->phy.speeds_supported |= IXGBE_LINK_SPEED_2_5GB_FULL;
> -
> -	if (!hw->phy.autoneg_advertised &&
> -	    hw->device_id == IXGBE_DEV_ID_E610_2_5G_T)
> -		hw->phy.autoneg_advertised = hw->phy.speeds_supported;
> -
> -	if (phy_type_low  & IXGBE_PHY_TYPE_LOW_5GBASE_T  ||
> -	    phy_type_low  & IXGBE_PHY_TYPE_LOW_5GBASE_KR ||
> -	    phy_type_high & IXGBE_PHY_TYPE_HIGH_5G_USXGMII)
> -		hw->phy.speeds_supported |= IXGBE_LINK_SPEED_5GB_FULL;
> -
>   	/* Set PHY ID */
>   	memcpy(&hw->phy.id, pcaps.phy_id_oui, sizeof(u32));
>