netdev - RE: [Intel-wired-lan] [PATCH iwl-next v1] igbvf: add tx_timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA3PR11MB898508E41FB217EF240FB5E98F43A@IA3PR11MB8985.namprd11.prod.outlook.com>
Date: Thu, 3 Jul 2025 14:12:39 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>, Kohei Enju
	<enjuk@...zon.com>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S . Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Kohei Enju <kohei.enju@...il.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v1] igbvf: add tx_timeout_count
 to ethtool statistics

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Loktionov, Aleksandr
> Sent: Thursday, June 12, 2025 6:36 PM
> To: Kohei Enju <enjuk@...zon.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; Andrew Lunn
> <andrew+netdev@...n.ch>; David S . Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; Kohei Enju <kohei.enju@...il.com>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1] igbvf: add tx_timeout_count to
> ethtool statistics
> 
> 
> 
> > -----Original Message-----
> > From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> > Of Kohei Enju
> > Sent: Thursday, June 12, 2025 6:16 PM
> > To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel,
> > Przemyslaw <przemyslaw.kitszel@...el.com>
> > Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; Andrew
> > Lunn <andrew+netdev@...n.ch>; David S . Miller <davem@...emloft.net>;
> > Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>;
> > Paolo Abeni <pabeni@...hat.com>; Kohei Enju <kohei.enju@...il.com>;
> > Kohei Enju <enjuk@...zon.com>
> > Subject: [Intel-wired-lan] [PATCH iwl-next v1] igbvf: add
> > tx_timeout_count to ethtool statistics
> >
> > Add `tx_timeout_count` to ethtool statistics to provide visibility
> > into transmit timeout events, bringing igbvf in line with other Intel
> > ethernet drivers.
> >
> > Currently `tx_timeout_count` is incremented in igbvf_watchdog_task()
> > and
> > igbvf_tx_timeout() but is not exposed to userspace nor used elsewhere
> > in the driver.
> >
> > Before:
> >   # ethtool -S ens5 | grep tx
> >        tx_packets: 43
> >        tx_bytes: 4408
> >        tx_restart_queue: 0
> >
> > After:
> >   # ethtool -S ens5 | grep tx
> >        tx_packets: 41
> >        tx_bytes: 4241
> >        tx_restart_queue: 0
> >        tx_timeout_count: 0
> >
> > Tested-by: Kohei Enju <enjuk@...zon.com>
> > Signed-off-by: Kohei Enju <enjuk@...zon.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> > ---
> >  drivers/net/ethernet/intel/igbvf/ethtool.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ethernet/intel/igbvf/ethtool.c
> > b/drivers/net/ethernet/intel/igbvf/ethtool.c
> > index 83b97989a6bd..773895c663fd 100644
> > --- a/drivers/net/ethernet/intel/igbvf/ethtool.c
> > +++ b/drivers/net/ethernet/intel/igbvf/ethtool.c
> > @@ -33,6 +33,7 @@ static const struct igbvf_stats
> > igbvf_gstrings_stats[] = {
> >  	{ "lbrx_bytes", IGBVF_STAT(stats.gorlbc, stats.base_gorlbc) },
> >  	{ "lbrx_packets", IGBVF_STAT(stats.gprlbc, stats.base_gprlbc) },
> >  	{ "tx_restart_queue", IGBVF_STAT(restart_queue, zero_base) },
> > +	{ "tx_timeout_count", IGBVF_STAT(tx_timeout_count, zero_base)
> > },
> >  	{ "rx_long_byte_count", IGBVF_STAT(stats.gorc, stats.base_gorc) },
> >  	{ "rx_csum_offload_good", IGBVF_STAT(hw_csum_good, zero_base) },
> >  	{ "rx_csum_offload_errors", IGBVF_STAT(hw_csum_err, zero_base) },
> > --
> > 2.49.0


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>