netdev - Re: [PATCH v7] dt-bindings: net: Convert socfpga-dwmac bindings to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqLrLJ6wiqBk31NhronsUqX4_5FN-Lb26r-3SceDD7kkAA@mail.gmail.com>
Date: Thu, 3 Jul 2025 10:30:32 -0500
From: Rob Herring <robh@...nel.org>
To: Matthew Gerlach <matthew.gerlach@...era.com>
Cc: dinguyen@...nel.org, andrew+netdev@...n.ch, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, krzk+dt@...nel.org, 
	conor+dt@...nel.org, maxime.chevallier@...tlin.com, mcoquelin.stm32@...il.com, 
	alexandre.torgue@...s.st.com, richardcochran@...il.com, 
	netdev@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, 
	linux-arm-kernel@...ts.infradead.org, Mun Yew Tham <mun.yew.tham@...era.com>
Subject: Re: [PATCH v7] dt-bindings: net: Convert socfpga-dwmac bindings to yaml

On Mon, Jun 30, 2025 at 4:38 PM Matthew Gerlach
<matthew.gerlach@...era.com> wrote:
>
> Convert the bindings for socfpga-dwmac to yaml. Since the original
> text contained descriptions for two separate nodes, two separate
> yaml files were created.

Did you test this against your dts files?:

ethernet@...04000 (altr,socfpga-stmmac-a10-s10): iommus: [[11, 3]] is too short
ethernet@...02000 (altr,socfpga-stmmac-a10-s10): iommus: [[11, 2]] is too short
ethernet@...00000 (altr,socfpga-stmmac-a10-s10): iommus: [[11, 1]] is too short

There's also one for 'phy-addr', but that needs to be dropped from the
.dts files as it doesn't appear to be used.

[...]

> +  iommus:
> +    maxItems: 2

You need to add:

minItems: 1


Rob