netdev - Re: [PATCH iwl-net v1 1/2] devlink: allow driver to freely name interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <my4wiyu5dqlalt45e5pz2dfhjm3ytbnshhhjqlcdetp357z7u6@zvnq7wfcunlv>
Date: Fri, 4 Jul 2025 11:17:23 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, anthony.l.nguyen@...el.com, 
	netdev@...r.kernel.org, david.kaplan@....com, dhowells@...hat.com, 
	Przemek Kitszel <przemyslaw.kitszel@...el.com>
Subject: Re: [PATCH iwl-net v1 1/2] devlink: allow driver to freely name
 interfaces

Thu, Jul 03, 2025 at 01:30:21PM +0200, jedrzej.jagielski@...el.com wrote:
>Currently when adding devlink port it is prohibited to let
>a driver name an interface on its own. In some scenarios
>it would not be preferable to provide such limitation.
>
>Remove triggering the warning when ndo_get_phys_port_name() is
>implemented for driver which interface is about to get a devlink
>port on.

What's the reason for this? If you are missing some formatting, you
should add it to devlink.

Please don't to this.

>
>Suggested-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
>Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
>---
> net/devlink/port.c | 17 -----------------
> 1 file changed, 17 deletions(-)
>
>diff --git a/net/devlink/port.c b/net/devlink/port.c
>index 939081a0e615..f885c8e73307 100644
>--- a/net/devlink/port.c
>+++ b/net/devlink/port.c
>@@ -1161,23 +1161,6 @@ static void devlink_port_type_netdev_checks(struct devlink_port *devlink_port,
> {
> 	const struct net_device_ops *ops = netdev->netdev_ops;
> 
>-	/* If driver registers devlink port, it should set devlink port
>-	 * attributes accordingly so the compat functions are called
>-	 * and the original ops are not used.
>-	 */
>-	if (ops->ndo_get_phys_port_name) {
>-		/* Some drivers use the same set of ndos for netdevs
>-		 * that have devlink_port registered and also for
>-		 * those who don't. Make sure that ndo_get_phys_port_name
>-		 * returns -EOPNOTSUPP here in case it is defined.
>-		 * Warn if not.
>-		 */
>-		char name[IFNAMSIZ];
>-		int err;
>-
>-		err = ops->ndo_get_phys_port_name(netdev, name, sizeof(name));
>-		WARN_ON(err != -EOPNOTSUPP);
>-	}
> 	if (ops->ndo_get_port_parent_id) {
> 		/* Some drivers use the same set of ndos for netdevs
> 		 * that have devlink_port registered and also for
>-- 
>2.31.1
>