netdev - Re: [PATCH v2] net/sched: sch_qfq: Fix null-deref in agg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGdceCwEZ/cwzKq9@pop-os.localdomain>
Date: Thu, 3 Jul 2025 21:45:44 -0700
From: Cong Wang <xiyou.wangcong@...il.com>
To: Xiang Mei <xmei5@....edu>
Cc: gregkh@...uxfoundation.org, netdev@...r.kernel.org, jhs@...atatu.com,
	jiri@...nulli.us, security@...nel.org
Subject: Re: [PATCH v2] net/sched: sch_qfq: Fix null-deref in agg_dequeue

On Wed, Jul 02, 2025 at 01:30:01AM -0700, Xiang Mei wrote:
>  include/net/sch_generic.h | 24 ++++++++++++++++++++++++
>  net/sched/sch_api.c       | 10 ----------
>  net/sched/sch_hfsc.c      | 16 ----------------
>  net/sched/sch_qfq.c       |  2 +-
>  4 files changed, 25 insertions(+), 27 deletions(-)

Looks like you missed the declaration of qdisc_warn_nonwc()?

$ git grep qdisc_warn_nonwc -- include/
include/net/pkt_sched.h:void qdisc_warn_nonwc(const char *txt, struct Qdisc *qdisc);

I suggest moving both inlined functions to include/net/pkt_sched.h.
Sorry for not noticing this earlier.

Thanks!