netdev - [PATCH ipsec 0/2] ipsec: fix splat due to ipcomp fallback tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <cover.1751640074.git.sd@queasysnail.net>
Date: Fri,  4 Jul 2025 16:54:32 +0200
From: Sabrina Dubroca <sd@...asysnail.net>
To: netdev@...r.kernel.org
Cc: Steffen Klassert <steffen.klassert@...unet.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Cong Wang <xiyou.wangcong@...il.com>,
	Sabrina Dubroca <sd@...asysnail.net>
Subject: [PATCH ipsec 0/2] ipsec: fix splat due to ipcomp fallback tunnel

IPcomp tunnel states have an associated fallback tunnel, a keep a
reference on the corresponding xfrm_state, to allow deleting that
extra state when it's not needed anymore. These states cause issues
during netns deletion.

Commit f75a2804da39 ("xfrm: destroy xfrm_state synchronously on net
exit path") tried to address these problems but doesn't fully solve
them, and slowed down netns deletion by adding one synchronize_rcu per
deleted state.

The first patch solves the problem by moving the fallback state
deletion earlier (when we delete the user state, rather than at
destruction), then we can revert the previous fix.

Sabrina Dubroca (2):
  xfrm: delete x->tunnel as we delete x
  Revert "xfrm: destroy xfrm_state synchronously on net exit path"

 include/net/xfrm.h      | 13 +++----------
 net/ipv4/ipcomp.c       |  2 ++
 net/ipv6/ipcomp6.c      |  2 ++
 net/ipv6/xfrm6_tunnel.c |  2 +-
 net/key/af_key.c        |  2 +-
 net/xfrm/xfrm_ipcomp.c  |  1 -
 net/xfrm/xfrm_state.c   | 40 ++++++++++++++++------------------------
 net/xfrm/xfrm_user.c    |  2 +-
 8 files changed, 26 insertions(+), 38 deletions(-)

-- 
2.50.0