netdev - Re: [PATCH net-next] tcp: update the comment for tcp_process_tlp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMaK5_gQyf17MWgg_gV-YRNtVdA20aR3viNcsn-5_=bkW-G44w@mail.gmail.com>
Date: Fri, 4 Jul 2025 23:25:59 +0800
From: Xin Guo <guoxin0309@...il.com>
To: Neal Cardwell <ncardwell@...gle.com>
Cc: edumazet@...gle.com, davem@...emloft.net, dsahern@...nel.org, 
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: update the comment for tcp_process_tlp_ack()

thanks neal, I will send v2 to include the other outdated references.

Regards
Guo Xin

On Fri, Jul 4, 2025 at 11:19 PM Neal Cardwell <ncardwell@...gle.com> wrote:
>
> On Fri, Jul 4, 2025 at 10:49 AM xin.guo <guoxin0309@...il.com> wrote:
> >
> > As ACK-TLP was published as a standards-track RFC8985,
>
> nit: typo: s/ACK-TLP/RACK-TLP/
>
> > so the comment for tcp_process_tlp_ack() is outdated.
> >
> > Signed-off-by: xin.guo <guoxin0309@...il.com>
> > ---
> >  net/ipv4/tcp_input.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
> > index 79e3bfb0108f..e9e654f09180 100644
> > --- a/net/ipv4/tcp_input.c
> > +++ b/net/ipv4/tcp_input.c
> > @@ -3714,7 +3714,7 @@ static int tcp_replace_ts_recent(struct tcp_sock *tp, u32 seq)
> >  }
> >
> >  /* This routine deals with acks during a TLP episode and ends an episode by
> > - * resetting tlp_high_seq. Ref: TLP algorithm in draft-ietf-tcpm-rack
> > + * resetting tlp_high_seq. Ref: TLP algorithm in RFC8985
>
> Thanks for updating this! This looks good, but in net-next at
> 6b9fd8857b9fc I see two other outdated references to
> draft-ietf-tcpm-rack. Can you please fix the other two as well:
>
> git grep -n draft-ietf-tcpm-rack 6b9fd8857b9fc
>
> 6b9fd8857b9fc:Documentation/networking/ip-sysctl.rst:434:       losses
> into fast recovery (draft-ietf-tcpm-rack). Note that
>
> 6b9fd8857b9fc:net/ipv4/tcp_input.c:3717: * resetting tlp_high_seq.
> Ref: TLP algorithm in draft-ietf-tcpm-rack
>
> 6b9fd8857b9fc:net/ipv4/tcp_recovery.c:38:/* RACK loss detection (IETF
> draft draft-ietf-tcpm-rack-01):
>
> thanks,
> neal