lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAPpSM+TOikVgwiCFZSAT2iON8JBdRuQ7dRYaMJh4KPvT+jPs9g@mail.gmail.com> Date: Sat, 5 Jul 2025 14:24:08 -0700 From: Xiang Mei <xmei5@....edu> To: Cong Wang <xiyou.wangcong@...il.com> Cc: gregkh@...uxfoundation.org, netdev@...r.kernel.org, jhs@...atatu.com, jiri@...nulli.us, security@...nel.org Subject: Re: [PATCH v2] net/sched: sch_qfq: Fix null-deref in agg_dequeue Thanks for your code review. After reviewing the purpose and order of these header files, I found that your suggestion makes more sense. On Thu, Jul 3, 2025 at 9:45 PM Cong Wang <xiyou.wangcong@...il.com> wrote: > > On Wed, Jul 02, 2025 at 01:30:01AM -0700, Xiang Mei wrote: > > include/net/sch_generic.h | 24 ++++++++++++++++++++++++ > > net/sched/sch_api.c | 10 ---------- > > net/sched/sch_hfsc.c | 16 ---------------- > > net/sched/sch_qfq.c | 2 +- > > 4 files changed, 25 insertions(+), 27 deletions(-) > > Looks like you missed the declaration of qdisc_warn_nonwc()? > > $ git grep qdisc_warn_nonwc -- include/ > include/net/pkt_sched.h:void qdisc_warn_nonwc(const char *txt, struct Qdisc *qdisc); > > I suggest moving both inlined functions to include/net/pkt_sched.h. > Sorry for not noticing this earlier. > > Thanks!
Powered by blists - more mailing lists