netdev - Re: [PATCH v3 02/19] psp: base PSP device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <686a96ed46da5_3ad0f32941e@willemb.c.googlers.com.notmuch>
Date: Sun, 06 Jul 2025 11:31:57 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Daniel Zahka <daniel.zahka@...il.com>, 
 Donald Hunter <donald.hunter@...il.com>, 
 Jakub Kicinski <kuba@...nel.org>, 
 "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Paolo Abeni <pabeni@...hat.com>, 
 Simon Horman <horms@...nel.org>, 
 Jonathan Corbet <corbet@....net>, 
 Andrew Lunn <andrew+netdev@...n.ch>
Cc: Saeed Mahameed <saeedm@...dia.com>, 
 Leon Romanovsky <leon@...nel.org>, 
 Tariq Toukan <tariqt@...dia.com>, 
 Boris Pismenny <borisp@...dia.com>, 
 Kuniyuki Iwashima <kuniyu@...gle.com>, 
 Willem de Bruijn <willemb@...gle.com>, 
 David Ahern <dsahern@...nel.org>, 
 Neal Cardwell <ncardwell@...gle.com>, 
 Patrisious Haddad <phaddad@...dia.com>, 
 Raed Salem <raeds@...dia.com>, 
 Jianbo Liu <jianbol@...dia.com>, 
 Dragos Tatulea <dtatulea@...dia.com>, 
 Rahul Rameshbabu <rrameshbabu@...dia.com>, 
 Stanislav Fomichev <sdf@...ichev.me>, 
 Toke Høiland-Jørgensen <toke@...hat.com>, 
 Alexander Lobakin <aleksander.lobakin@...el.com>, 
 Jacob Keller <jacob.e.keller@...el.com>, 
 netdev@...r.kernel.org
Subject: Re: [PATCH v3 02/19] psp: base PSP device support

Daniel Zahka wrote:
> From: Jakub Kicinski <kuba@...nel.org>
> 
> Add a netlink family for PSP and allow drivers to register support.
> 
> The "PSP device" is its own object. This allows us to perform more
> flexible reference counting / lifetime control than if PSP information
> was part of net_device. In the future we should also be able
> to "delegate" PSP access to software devices, such as *vlan, veth
> or netkit more easily.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Daniel Zahka <daniel.zahka@...il.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>

Minor points only

> +/**
> + * struct psp_dev - PSP device struct
> + * @main_netdev: original netdevice of this PSP device
> + * @ops:	driver callbacks
> + * @caps:	device capabilities
> + * @drv_priv:	driver priv pointer
> + * @lock:	instance lock, protects all fields
> + * @refcnt:	reference count for the instance
> + * @id:		instance id
> + * @config:	current device configuration
> + *
> + * @rcu:	RCU head for freeing the structure
> + */
> +struct psp_dev {
> +	struct net_device *main_netdev;
> +
> +	struct psp_dev_ops *ops;
> +	struct psp_dev_caps *caps;
> +	void *drv_priv;

not used?

> +
> +	struct mutex lock;
> +	refcount_t refcnt;
> +
> +	u32 id;
> +
> +	struct psp_dev_config config;
> +
> +	struct rcu_head rcu;
> +};
> +
> +/**
> + * struct psp_dev_caps - PSP device capabilities
> + */
> +struct psp_dev_caps {
> +	/**
> +	 * @versions: mask of supported PSP versions
> +	 * Set this field to 0 to indicate PSP is not supported at all.
> +	 */
> +	u32 versions;
> +};
> +
> +#define PSP_V0_KEY	16
> +#define PSP_V1_KEY	32

Above two not used? And these and the following are are KEY_LEN

> +#define PSP_MAX_KEY	32