netdev - RE: [PATCH 0/3] net: renesas: rswitch: R-Car S4 add HW offloading for layer 2 switching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TY4PR01MB14282E8A9E82714106D448EA0824FA@TY4PR01MB14282.jpnprd01.prod.outlook.com>
Date: Mon, 7 Jul 2025 10:41:06 +0000
From: Michael Dege <michael.dege@...esas.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	Niklas Söderlund <niklas.soderlund@...natech.se>, Paul
 Barker <paul@...rker.dev>, Andrew Lunn <andrew+netdev@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Nikita
 Yushchenko <nikita.yoush@...entembedded.com>
Subject: RE: [PATCH 0/3] net: renesas: rswitch: R-Car S4 add HW offloading for
 layer 2 switching

Hello Andrew,

> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Friday, July 4, 2025 10:34 AM
> To: Michael Dege <michael.dege@...esas.com>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>; Niklas Söderlund
> <niklas.soderlund@...natech.se>; Paul Barker <paul@...rker.dev>; Andrew Lunn <andrew+netdev@...n.ch>;
> David S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski
> <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; netdev@...r.kernel.org; linux-renesas-
> soc@...r.kernel.org; linux-kernel@...r.kernel.org; Nikita Yushchenko <nikita.yoush@...entembedded.com>
> Subject: Re: [PATCH 0/3] net: renesas: rswitch: R-Car S4 add HW offloading for layer 2 switching
>
> On Fri, Jul 04, 2025 at 07:51:14AM +0200, Michael Dege wrote:
> > Hello!
> >
> > The current R-Car S4 rswitch driver only supports port based fowarding.
> > This patch set adds HW offloading for L2 switching/bridgeing. The
> > driver hooks into switchdev.
> >
> > 1. Rename the base driver file to keep the driver name (rswitch.ko)
> >
> > 2. Add the L2 driver extension in a separate file. The HW offloading
> > is automatically configured when a port is added to the bridge device.
> >
> > Ussage example:
> > ip link add name br type bridge
> > ip link set dev tsn0 master br
> > ip link set dev tsn1 master br
> > ip link set dev br up
> > ip link set dev tsn0 up
> > ip link set dev tsn1 up
>
> It is not wrong, but it is normal for an interface to have a number of some sort. So br0.
>
> >
> > Layer 2 traffic is now fowarded by HW from port TSN0 to port TSN1.
> >
> > 3. Provides the functionality to set the MAC table ageing time in the
> > Rswitch.
> >
> > Usage example:
> > brctl setageing br 300
>
> brctl is deprecated. iproute2 has a method to do this, which would be a better reference to give.

There is a discrepancy between the value being passed by iproute2 and brctl. Iproute2 passes the
value unaltered in seconds and brctl passes the value in seconds multiplied by 100. So far this
is OK because brctl is deprecated. But the default value being passed when neither brctl is called
nor the ageing parameter is added when the bridge is created is also multiplied by 100 resulting in
30000s being set as default ageing time instead of 300s. Is this a known issue?

Best regards,

Michael

>
>   Andrew
________________________________

Renesas Electronics Europe GmbH
Registered Office: Arcadiastrasse 10
DE-40472 Duesseldorf
Commercial Registry: Duesseldorf, HRB 3708
Managing Director: Carsten Jauch
VAT-No.: DE 14978647
Tax-ID-No: 105/5839/1793

Legal Disclaimer: This e-mail communication (and any attachment/s) is confidential and contains proprietary information, some or all of which may be legally privileged. It is intended solely for the use of the individual or entity to which it is addressed. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful.