netdev - Re: [PATCH v21 net-next 1/6] sched: Struct definition and parsing of dualpi2 qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13b00d4f-ad0a-409a-b9c1-0f4e195450a9@redhat.com>
Date: Tue, 8 Jul 2025 12:29:13 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: chia-yu.chang@...ia-bell-labs.com, alok.a.tiwari@...cle.com,
 pctammela@...atatu.com, horms@...nel.org, donald.hunter@...il.com,
 xandfury@...il.com, netdev@...r.kernel.org, dave.taht@...il.com,
 jhs@...atatu.com, kuba@...nel.org, stephen@...workplumber.org,
 xiyou.wangcong@...il.com, jiri@...nulli.us, davem@...emloft.net,
 edumazet@...gle.com, andrew+netdev@...n.ch, ast@...erby.net,
 liuhangbin@...il.com, shuah@...nel.org, linux-kselftest@...r.kernel.org,
 ij@...nel.org, ncardwell@...gle.com, koen.de_schepper@...ia-bell-labs.com,
 g.white@...lelabs.com, ingemar.s.johansson@...csson.com,
 mirja.kuehlewind@...csson.com, cheshire@...le.com, rs.ietf@....at,
 Jason_Livingood@...cast.com, vidhi_goel@...le.com
Subject: Re: [PATCH v21 net-next 1/6] sched: Struct definition and parsing of
 dualpi2 qdisc

On 7/2/25 5:28 AM, chia-yu.chang@...ia-bell-labs.com wrote:
> +static int dualpi2_change(struct Qdisc *sch, struct nlattr *opt,
> +			  struct netlink_ext_ack *extack)
> +{
> +	struct nlattr *tb[TCA_DUALPI2_MAX + 1];
> +	struct dualpi2_sched_data *q;
> +	int old_backlog;
> +	int old_qlen;
> +	int err;
> +
> +	if (!opt) {
> +		NL_SET_ERR_MSG_MOD(extack, "Dualpi2 options are reuqired");

Minor note: typo above ("reuqired" -> "required")

More importantly: the above is inconsistent with the below code, where
AFAICS it's not enforced/mandated the presence of any Dualpi2 option.

i.e. User space could successfully provide a TCA_OPTIONS with no nested
attributes.

Am I missing something?

Thanks,

Paolo