netdev - Re: [PATCH v3 02/19] psp: base PSP device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <686c6f9d25851_266852947d@willemb.c.googlers.com.notmuch>
Date: Mon, 07 Jul 2025 21:08:45 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, 
 Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: Daniel Zahka <daniel.zahka@...il.com>, 
 Donald Hunter <donald.hunter@...il.com>, 
 "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Paolo Abeni <pabeni@...hat.com>, 
 Simon Horman <horms@...nel.org>, 
 Jonathan Corbet <corbet@....net>, 
 Andrew Lunn <andrew+netdev@...n.ch>, 
 Saeed Mahameed <saeedm@...dia.com>, 
 Leon Romanovsky <leon@...nel.org>, 
 Tariq Toukan <tariqt@...dia.com>, 
 Boris Pismenny <borisp@...dia.com>, 
 Kuniyuki Iwashima <kuniyu@...gle.com>, 
 Willem de Bruijn <willemb@...gle.com>, 
 David Ahern <dsahern@...nel.org>, 
 Neal Cardwell <ncardwell@...gle.com>, 
 Patrisious Haddad <phaddad@...dia.com>, 
 Raed Salem <raeds@...dia.com>, 
 Jianbo Liu <jianbol@...dia.com>, 
 Dragos Tatulea <dtatulea@...dia.com>, 
 Rahul Rameshbabu <rrameshbabu@...dia.com>, 
 Stanislav Fomichev <sdf@...ichev.me>, 
 Toke Høiland-Jørgensen <toke@...hat.com>, 
 Alexander Lobakin <aleksander.lobakin@...el.com>, 
 Jacob Keller <jacob.e.keller@...el.com>, 
 netdev@...r.kernel.org
Subject: Re: [PATCH v3 02/19] psp: base PSP device support

Jakub Kicinski wrote:
> On Sun, 06 Jul 2025 11:31:57 -0400 Willem de Bruijn wrote:
> > > +/**
> > > + * struct psp_dev - PSP device struct
> > > + * @main_netdev: original netdevice of this PSP device
> > > + * @ops:	driver callbacks
> > > + * @caps:	device capabilities
> > > + * @drv_priv:	driver priv pointer
> > > + * @lock:	instance lock, protects all fields
> > > + * @refcnt:	reference count for the instance
> > > + * @id:		instance id
> > > + * @config:	current device configuration
> > > + *
> > > + * @rcu:	RCU head for freeing the structure
> > > + */
> > > +struct psp_dev {
> > > +	struct net_device *main_netdev;
> > > +
> > > +	struct psp_dev_ops *ops;
> > > +	struct psp_dev_caps *caps;
> > > +	void *drv_priv;  
> > 
> > not used?
> 
> I'd rather keep it from the start. The driver-facing API needs to be
> relatively complete otherwise drive authors will work around what's
> missing rather than adding it :(

Sounds good.