netdev - Re: [PATCH net-next 08/11] net_sched: act_nat: use RCU in tcf_nat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iKFibV=AXC+z8f1xvvJBJA9ydkxczw-0Ged2RTQ+O=cqA@mail.gmail.com>
Date: Tue, 8 Jul 2025 06:20:32 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Simon Horman <horms@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Jamal Hadi Salim <jhs@...atatu.com>, 
	Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, 
	Kuniyuki Iwashima <kuniyu@...gle.com>, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 08/11] net_sched: act_nat: use RCU in tcf_nat_dump()

On Tue, Jul 8, 2025 at 5:54 AM Simon Horman <horms@...nel.org> wrote:
>
> On Mon, Jul 07, 2025 at 01:01:07PM +0000, Eric Dumazet wrote:
> > Also storing tcf_action into struct tcf_nat_params
> > makes sure there is no discrepancy in tcf_nat_act().
> >
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>
> ...

> > @@ -294,12 +293,12 @@ static int tcf_nat_dump(struct sk_buff *skb, struct tc_action *a,
> >       tcf_tm_dump(&t, &p->tcf_tm);
> >       if (nla_put_64bit(skb, TCA_NAT_TM, sizeof(t), &t, TCA_NAT_PAD))
> >               goto nla_put_failure;
> > -     spin_unlock_bh(&p->tcf_lock);
> > +     rcu_read_lock();
>

Absolutely, thank you for catching this.