netdev - RE: [Intel-wired-lan] [PATCH iwl-next 6/8] ice: use pci_iov_vf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8985E041208546CD2E945EDA8F4EA@IA3PR11MB8985.namprd11.prod.outlook.com>
Date: Tue, 8 Jul 2025 14:59:38 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: "Keller, Jacob E" <jacob.e.keller@...el.com>, Intel Wired LAN
	<intel-wired-lan@...ts.osuosl.org>
CC: "Keller, Jacob E" <jacob.e.keller@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Chittim, Madhu" <madhu.chittim@...el.com>, "Cao,
 Yahui" <yahui.cao@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next 6/8] ice: use pci_iov_vf_id()
 to get VF ID

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Jacob Keller
> Sent: Thursday, June 19, 2025 12:25 AM
> To: Intel Wired LAN <intel-wired-lan@...ts.osuosl.org>
> Cc: Keller, Jacob E <jacob.e.keller@...el.com>; netdev@...r.kernel.org;
> Chittim, Madhu <madhu.chittim@...el.com>; Cao, Yahui
> <yahui.cao@...el.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>;
> Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next 6/8] ice: use pci_iov_vf_id() to get
> VF ID
>
> The ice_sriov_set_msix_vec_count() obtains the VF device ID in a strange way
> by iterating over the possible VF IDs and calling pci_iov_virtfn_devfn to
> calculate the device and function combos and compare them to the pdev-
> >devfn.
>
> This is unnecessary. The pci_iov_vf_id() helper already exists which does the
> reverse calculation of pci_iov_virtfn_devfn(), which is much simpler and avoids
> the loop construction. Use this instead.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_sriov.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_sriov.c
> b/drivers/net/ethernet/intel/ice/ice_sriov.c
> index
> 8d77c387357bbba27fbcec4bb2019274d2a2eb99..4c0955be2ad20c3902cf
> 891a66f857585fcab98b 100644
> --- a/drivers/net/ethernet/intel/ice/ice_sriov.c
> +++ b/drivers/net/ethernet/intel/ice/ice_sriov.c
> @@ -952,17 +952,11 @@ int ice_sriov_set_msix_vec_count(struct pci_dev

Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>