netdev - Re: [PATCH bpf-next v3 0/7] Add attach_type in bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zfddepu6.fsf@cloudflare.com>
Date: Wed, 09 Jul 2025 10:22:09 +0200
From: Jakub Sitnicki <jakub@...udflare.com>
To: Tao Chen <chen.dylane@...ux.dev>
Cc: daniel@...earbox.net,  razor@...ckwall.org,  andrew+netdev@...n.ch,
  davem@...emloft.net,  edumazet@...gle.com,  kuba@...nel.org,
  pabeni@...hat.com,  ast@...nel.org,  andrii@...nel.org,
  martin.lau@...ux.dev,  eddyz87@...il.com,  song@...nel.org,
  yonghong.song@...ux.dev,  john.fastabend@...il.com,  kpsingh@...nel.org,
  sdf@...ichev.me,  haoluo@...gle.com,  jolsa@...nel.org,
  mattbobrowski@...gle.com,  rostedt@...dmis.org,  mhiramat@...nel.org,
  mathieu.desnoyers@...icios.com,  horms@...nel.org,  willemb@...gle.com,
  pablo@...filter.org,  kadlec@...filter.org,  hawk@...nel.org,
  bpf@...r.kernel.org,  netdev@...r.kernel.org,
  linux-kernel@...r.kernel.org,  linux-trace-kernel@...r.kernel.org,
  netfilter-devel@...r.kernel.org,  coreteam@...filter.org
Subject: Re: [PATCH bpf-next v3 0/7] Add attach_type in bpf_link

On Wed, Jul 09, 2025 at 11:07 AM +08, Tao Chen wrote:
> Andrii suggested moving the attach_type into bpf_link, the previous discussion
> is as follows:
> https://lore.kernel.org/bpf/CAEf4BzY7TZRjxpCJM-+LYgEqe23YFj5Uv3isb7gat2-HU4OSng@mail.gmail.com
>
> patch1 add attach_type in bpf_link, and pass it to bpf_link_init, which
> will init the attach_type field.
>
> patch2-7 remove the attach_type in struct bpf_xx_link, update the info
> with bpf_link attach_type.
>
> There are some functions finally call bpf_link_init but do not have bpf_attr
> from user or do not need to init attach_type from user like bpf_raw_tracepoint_open,
> now use prog->expected_attach_type to init attach_type.
>
> bpf_struct_ops_map_update_elem
> bpf_raw_tracepoint_open
> bpf_struct_ops_test_run
>
> Feedback of any kind is welcome, thanks.
>
> Tao Chen (7):
>   bpf: Add attach_type in bpf_link
>   bpf: Remove attach_type in bpf_cgroup_link
>   bpf: Remove attach_type in sockmap_link
>   bpf: Remove location field in tcx_link
>   bpf: Remove attach_type in bpf_netns_link
>   bpf: Remove attach_type in bpf_tracing_link
>   netkit: Remove location field in netkit_link

For the series:

Reviewed-by: Jakub Sitnicki <jakub@...udflare.com>