netdev - Re: [PATCH net 1/3] net: libwx: remove duplicate page_pool_put_full

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250709114707.GX452973@horms.kernel.org>
Date: Wed, 9 Jul 2025 12:47:07 +0100
From: Simon Horman <horms@...nel.org>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: netdev@...r.kernel.org, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	michal.kubiak@...el.com, mengyuanlou@...-swift.com,
	duanqiangwen@...-swift.com, stable@...r.kernel.org
Subject: Re: [PATCH net 1/3] net: libwx: remove duplicate
 page_pool_put_full_page()

On Wed, Jul 09, 2025 at 02:40:23PM +0800, Jiawen Wu wrote:

...

> diff --git a/drivers/net/ethernet/wangxun/libwx/wx_lib.c b/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> index 55e252789db3..7e3d7fb61a52 100644
> --- a/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> +++ b/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> @@ -174,10 +174,6 @@ static void wx_dma_sync_frag(struct wx_ring *rx_ring,
>  				      skb_frag_off(frag),
>  				      skb_frag_size(frag),
>  				      DMA_FROM_DEVICE);
> -
> -	/* If the page was released, just unmap it. */
> -	if (unlikely(WX_CB(skb)->page_released))
> -		page_pool_put_full_page(rx_ring->page_pool, rx_buffer->page, false);
>  }
>  
>  static struct wx_rx_buffer *wx_get_rx_buffer(struct wx_ring *rx_ring,
> @@ -227,10 +223,6 @@ static void wx_put_rx_buffer(struct wx_ring *rx_ring,
>  			     struct sk_buff *skb,
>  			     int rx_buffer_pgcnt)
>  {
> -	if (!IS_ERR(skb) && WX_CB(skb)->dma == rx_buffer->dma)
> -		/* the page has been released from the ring */
> -		WX_CB(skb)->page_released = true;
> -
>  	/* clear contents of rx_buffer */
>  	rx_buffer->page = NULL;
>  	rx_buffer->skb = NULL;
> @@ -2423,9 +2415,6 @@ static void wx_clean_rx_ring(struct wx_ring *rx_ring)
>  		if (rx_buffer->skb) {
>  			struct sk_buff *skb = rx_buffer->skb;
>  
> -			if (WX_CB(skb)->page_released)
> -				page_pool_put_full_page(rx_ring->page_pool, rx_buffer->page, false);
> -
>  			dev_kfree_skb(skb);
>  		}
>  

I think the page_released member of wx_cb.
It seems to be unused now.