netdev - Re: [PATCH net-next v3 5/8] net: s/__dev_set_mtu/__netif_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250709063554.7c771beb@kernel.org>
Date: Wed, 9 Jul 2025 06:35:54 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com
Subject: Re: [PATCH net-next v3 5/8] net: s/__dev_set_mtu/__netif_set_mtu/

On Tue,  8 Jul 2025 14:38:26 -0700 Stanislav Fomichev wrote:
>  int netif_set_mtu_ext(struct net_device *dev, int new_mtu,
>  		      struct netlink_ext_ack *extack)
>  {
>  	int err, orig_mtu;
>  
> +	netdev_assert_locked_or_invisible(dev);

This one fires, should it be ops-locked?

[ 3137.181693][T26830] ------------[ cut here ]------------
[ 3137.182161][T26830] WARNING: CPU: 1 PID: 26830 at ./include/net/netdev_lock.h:17 netif_set_mtu_ext+0x27f/0x5c0
[ 3137.185509][T26830] RIP: 0010:netif_set_mtu_ext+0x27f/0x5c0
[ 3137.193144][T26830]  do_setlink.constprop.0+0x6b1/0x2480
[ 3137.198661][T26830]  rtnl_newlink+0x69a/0xa60
-- 
pw-bot: cr