netdev - Re: [PATCH net-next v3 03/12] net: libwx: add wangxun vf common api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8efdcd7-bc06-4c91-910f-3337be7408de@linux.dev>
Date: Wed, 9 Jul 2025 14:51:52 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Mengyuan Lou <mengyuanlou@...-swift.com>, netdev@...r.kernel.org
Cc: michal.swiatkowski@...ux.intel.com, kuba@...nel.org, pabeni@...hat.com,
 horms@...nel.org, andrew+netdev@...n.ch, duanqiangwen@...-swift.com,
 linglingzhang@...stnetic.com, jiawenwu@...stnetic.com
Subject: Re: [PATCH net-next v3 03/12] net: libwx: add wangxun vf common api

On 04/07/2025 10:49, Mengyuan Lou wrote:
> Add common wx_configure_vf and wx_set_mac_vf for
> ngbevf and txgbevf.
> 
> Signed-off-by: Mengyuan Lou <mengyuanlou@...-swift.com>
> ---
>   drivers/net/ethernet/wangxun/libwx/Makefile   |   2 +-
>   drivers/net/ethernet/wangxun/libwx/wx_hw.c    |   3 +-
>   drivers/net/ethernet/wangxun/libwx/wx_hw.h    |   1 +
>   drivers/net/ethernet/wangxun/libwx/wx_type.h  |   4 +
>   drivers/net/ethernet/wangxun/libwx/wx_vf.h    |  50 ++++
>   .../net/ethernet/wangxun/libwx/wx_vf_common.c | 196 ++++++++++++
>   .../net/ethernet/wangxun/libwx/wx_vf_common.h |  14 +
>   .../net/ethernet/wangxun/libwx/wx_vf_lib.c    | 280 ++++++++++++++++++
>   .../net/ethernet/wangxun/libwx/wx_vf_lib.h    |  14 +
>   9 files changed, 562 insertions(+), 2 deletions(-)
>   create mode 100644 drivers/net/ethernet/wangxun/libwx/wx_vf_common.c
>   create mode 100644 drivers/net/ethernet/wangxun/libwx/wx_vf_common.h
>   create mode 100644 drivers/net/ethernet/wangxun/libwx/wx_vf_lib.c
>   create mode 100644 drivers/net/ethernet/wangxun/libwx/wx_vf_lib.h
> 

[...]

> diff --git a/drivers/net/ethernet/wangxun/libwx/wx_vf.h b/drivers/net/ethernet/wangxun/libwx/wx_vf.h
> index c523ef3e8502..e863a74c291d 100644
> --- a/drivers/net/ethernet/wangxun/libwx/wx_vf.h
> +++ b/drivers/net/ethernet/wangxun/libwx/wx_vf.h
> @@ -14,6 +14,7 @@
>   #define WX_VXMRQC                0x78
>   #define WX_VXICR                 0x100
>   #define WX_VXIMS                 0x108
> +#define WX_VXIMC                 0x10C
>   #define WX_VF_IRQ_CLEAR_MASK     7
>   #define WX_VF_MAX_TX_QUEUES      4
>   #define WX_VF_MAX_RX_QUEUES      4
> @@ -22,6 +23,12 @@
>   #define WX_VXRXDCTL_ENABLE       BIT(0)
>   #define WX_VXTXDCTL_FLUSH        BIT(26)
>   
> +#define WX_VXITR(i)              (0x200 + (4 * (i))) /* i=[0,1] */
> +#define WX_VXITR_MASK            GENMASK(8, 0)
> +#define WX_VXITR_CNT_WDIS        BIT(31)
> +#define WX_VXIVAR_MISC           0x260
> +#define WX_VXIVAR(i)             (0x240 + (4 * (i))) /* i=[0,3] */
> +
>   #define WX_VXRXDCTL_RSCMAX(f)    FIELD_PREP(GENMASK(24, 23), f)
>   #define WX_VXRXDCTL_BUFLEN(f)    FIELD_PREP(GENMASK(6, 1), f)
>   #define WX_VXRXDCTL_BUFSZ(f)     FIELD_PREP(GENMASK(11, 8), f)
> @@ -44,6 +51,49 @@
>   #define WX_RX_HDR_SIZE           256
>   #define WX_RX_BUF_SIZE           2048
>   
> +#define WX_RXBUFFER_2048         (2048)

extra parentheses are not needed

> +#define WX_RXBUFFER_3072         3072
> +
> +/* Receive Path */
> +#define WX_VXRDBAL(r)            (0x1000 + (0x40 * (r)))
> +#define WX_VXRDBAH(r)            (0x1004 + (0x40 * (r)))
> +#define WX_VXRDT(r)              (0x1008 + (0x40 * (r)))
> +#define WX_VXRDH(r)              (0x100C + (0x40 * (r)))

[...]