netdev - Re: [PATCH v2 net 1/3] atm: clip: Fix potential null-ptr-deref in to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250709185420.GK721198@horms.kernel.org>
Date: Wed, 9 Jul 2025 19:54:20 +0100
From: Simon Horman <horms@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net 1/3] atm: clip: Fix potential null-ptr-deref in
 to_atmarpd().

On Fri, Jul 04, 2025 at 06:23:51AM +0000, Kuniyuki Iwashima wrote:
> atmarpd is protected by RTNL since commit f3a0592b37b8 ("[ATM]: clip
> causes unregister hang").
> 
> However, it is not enough because to_atmarpd() is called without RTNL,
> especially clip_neigh_solicit() / neigh_ops->solicit() is unsleepable.
> 
> Also, there is no RTNL dependency around atmarpd.
> 
> Let's use a private mutex and RCU to protect access to atmarpd in
> to_atmarpd().
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...gle.com>
> ---
> v2: Add __rcu to silence Sparse

Reviewed-by: Simon Horman <horms@...nel.org>