netdev - Re: [PATCH net-next 2/5] selftests: drv-net: Test XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250709133745.2a8ddfb8@kernel.org>
Date: Wed, 9 Jul 2025 13:37:45 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Mohsin Bashir <mohsin.bashr@...il.com>
Cc: netdev@...r.kernel.org, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, shuah@...nel.org, horms@...nel.org,
 cratiu@...dia.com, noren@...dia.com, cjubran@...dia.com, mbloch@...dia.com,
 jdamato@...tly.com, gal@...dia.com, sdf@...ichev.me, bpf@...r.kernel.org
Subject: Re: [PATCH net-next 2/5] selftests: drv-net: Test XDP_PASS/DROP
 support

On Wed,  9 Jul 2025 10:37:04 -0700 Mohsin Bashir wrote:
> +#include <xdp/xdp_helpers.h>
> +#include <xdp/prog_dispatcher.h>

Hm, you don't appear to use these headers and they require installing
libxdp-devel (which is not universally packaged, sadly). Could you
remove? Also these headers are reportedly unused:

#include <linux/tcp.h>
#include <linux/bpf_common.h>
-- 
pw-bot: cr