[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250709140248.71603931@kernel.org>
Date: Wed, 9 Jul 2025 14:02:48 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: "Chia-Yu Chang (Nokia)" <chia-yu.chang@...ia-bell-labs.com>
Cc: Paolo Abeni <pabeni@...hat.com>, "alok.a.tiwari@...cle.com"
<alok.a.tiwari@...cle.com>, "pctammela@...atatu.com"
<pctammela@...atatu.com>, "horms@...nel.org" <horms@...nel.org>,
"donald.hunter@...il.com" <donald.hunter@...il.com>, "xandfury@...il.com"
<xandfury@...il.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"dave.taht@...il.com" <dave.taht@...il.com>, "jhs@...atatu.com"
<jhs@...atatu.com>, "stephen@...workplumber.org"
<stephen@...workplumber.org>, "xiyou.wangcong@...il.com"
<xiyou.wangcong@...il.com>, "jiri@...nulli.us" <jiri@...nulli.us>,
"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
<edumazet@...gle.com>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
"ast@...erby.net" <ast@...erby.net>, "liuhangbin@...il.com"
<liuhangbin@...il.com>, "shuah@...nel.org" <shuah@...nel.org>,
"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
"ij@...nel.org" <ij@...nel.org>, "ncardwell@...gle.com"
<ncardwell@...gle.com>, "Koen De Schepper (Nokia)"
<koen.de_schepper@...ia-bell-labs.com>, "g.white@...lelabs.com"
<g.white@...lelabs.com>, "ingemar.s.johansson@...csson.com"
<ingemar.s.johansson@...csson.com>, "mirja.kuehlewind@...csson.com"
<mirja.kuehlewind@...csson.com>, "cheshire@...le.com" <cheshire@...le.com>,
"rs.ietf@....at" <rs.ietf@....at>, "Jason_Livingood@...cast.com"
<Jason_Livingood@...cast.com>, "vidhi_goel@...le.com"
<vidhi_goel@...le.com>
Subject: Re: [PATCH v21 net-next 1/6] sched: Struct definition and parsing
of dualpi2 qdisc
On Wed, 9 Jul 2025 08:17:08 +0000 Chia-Yu Chang (Nokia) wrote:
> Thanks for clarification, then I will add one extra "int opt_flag = 0" and set the flag (e.g., opt_flag += 1 << TCA_DUALPI2_LIMIT).
>
> At the end will return an error message if no flag is set, like below example:
>
> if (!opt_flag) {
> sch_tree_unlock(sch);
> NL_SET_ERR_MSG_MOD(extack, "Dualpi2 options are empty");
> return -EINVAL;
> }
>
> Or is there any other suggested ways to do it, please let me know, thanks.
You don't have to track each option. I think it's enough to check if
the option nest is empty:
- if (!opt) {
+ if (!opt || !nla_len(opt)) {
Powered by blists - more mailing lists