netdev - Re: [PATCH iwl-next v2 1/5] e1000: drop unnecessary constant casts to u16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507091034.uiPhnpcc-lkp@intel.com>
Date: Wed, 9 Jul 2025 11:03:16 +0800
From: kernel test robot <lkp@...el.com>
To: Jacek Kowalski <jacek@...ekk.info>,
	Tony Nguyen <anthony.l.nguyen@...el.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	netdev@...r.kernel.org, intel-wired-lan@...ts.osuosl.org
Subject: Re: [PATCH iwl-next v2 1/5] e1000: drop unnecessary constant casts
 to u16

Hi Jacek,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tnguy-next-queue/dev-queue]

url:    https://github.com/intel-lab-lkp/linux/commits/Jacek-Kowalski/e1000-drop-unnecessary-constant-casts-to-u16/20250708-161919
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue
patch link:    https://lore.kernel.org/r/e199da76-00d0-43d3-8f61-f433bc0352ad%40jacekk.info
patch subject: [PATCH iwl-next v2 1/5] e1000: drop unnecessary constant casts to u16
config: riscv-randconfig-002-20250709 (https://download.01.org/0day-ci/archive/20250709/202507091034.uiPhnpcc-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 01c97b4953e87ae455bd4c41e3de3f0f0f29c61c)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250709/202507091034.uiPhnpcc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507091034.uiPhnpcc-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/intel/e1000/e1000_main.c:316:16: warning: result of comparison of constant -1 with expression of type 'u16' (aka 'unsigned short') is always true [-Wtautological-constant-out-of-range-compare]
     316 |                 if ((old_vid != E1000_MNG_VLAN_NONE) &&
         |                      ~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~
   1 warning generated.


vim +316 drivers/net/ethernet/intel/e1000/e1000_main.c

   297	
   298	static void e1000_update_mng_vlan(struct e1000_adapter *adapter)
   299	{
   300		struct e1000_hw *hw = &adapter->hw;
   301		struct net_device *netdev = adapter->netdev;
   302		u16 vid = hw->mng_cookie.vlan_id;
   303		u16 old_vid = adapter->mng_vlan_id;
   304	
   305		if (!e1000_vlan_used(adapter))
   306			return;
   307	
   308		if (!test_bit(vid, adapter->active_vlans)) {
   309			if (hw->mng_cookie.status &
   310			    E1000_MNG_DHCP_COOKIE_STATUS_VLAN_SUPPORT) {
   311				e1000_vlan_rx_add_vid(netdev, htons(ETH_P_8021Q), vid);
   312				adapter->mng_vlan_id = vid;
   313			} else {
   314				adapter->mng_vlan_id = E1000_MNG_VLAN_NONE;
   315			}
 > 316			if ((old_vid != E1000_MNG_VLAN_NONE) &&
   317			    (vid != old_vid) &&
   318			    !test_bit(old_vid, adapter->active_vlans))
   319				e1000_vlan_rx_kill_vid(netdev, htons(ETH_P_8021Q),
   320						       old_vid);
   321		} else {
   322			adapter->mng_vlan_id = vid;
   323		}
   324	}
   325	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki