netdev - Re: [devel-ipsec] [PATCH RFC ipsec-next] pfkey: Deprecate pfkey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aG4BV8I8ig67NhXS@moon.secunet.de>
Date: Wed, 9 Jul 2025 07:42:47 +0200
From: Antony Antony <antony.antony@...unet.com>
To: Steffen Klassert <steffen.klassert@...unet.com>
CC: Herbert Xu <herbert@...dor.apana.org.au>, Paul Wouters <paul@...ats.ca>,
	Andreas Steffen <andreas.steffen@...ongswan.org>, Tobias Brunner
	<tobias@...ongswan.org>, Antony Antony <antony@...nome.org>, Tuomo Soini
	<tis@...bar.fi>, "David S. Miller" <davem@...emloft.net>,
	<netdev@...r.kernel.org>, <devel@...ux-ipsec.org>, Leon Romanovsky
	<leon@...nel.org>
Subject: Re: [devel-ipsec] [PATCH RFC ipsec-next] pfkey: Deprecate pfkey

On Fri, Jul 04, 2025 at 08:55:14 +0200, Steffen Klassert via Devel wrote:
> The pfkey user configuration interface was replaced by the netlink
> user configuration interface more than a decade ago. In between
> all maintained IKE implementations moved to the netlink interface.
> So let 'config NET_KEY' default to no in Kconfig. The pfkey code
> will be removed in a second step.
> Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>

Acked-by: Antony Antony <antony.antony@...unet.com>

I have tested libreswan and strongSwan CONFIG_NET_KEY=n; without HW offload.

And I would also like to get a confirmation Hardware offload, crypt
offload and packet offload works with CONFIG_NET_KEY n.

I undderstand this patch is independent of HW offload.

However, IMHO it is good to confirm now.  Otherwise I imagine
distributions will flip CONFIG_NET_KEY=y to get HW offload working,
which will make it harder to depreciate PF_KEY/NET_KEY

Paul or Leon - would you like to confirm with
CONFIG_NET_KEY=n XFRM HW offload still works?

-antony

> ---
>  net/xfrm/Kconfig | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig
> index f0157702718f..aedea7a892db 100644
> --- a/net/xfrm/Kconfig
> +++ b/net/xfrm/Kconfig
> @@ -110,14 +110,17 @@ config XFRM_IPCOMP
>  	select CRYPTO_DEFLATE
>  
>  config NET_KEY
> -	tristate "PF_KEY sockets"
> +	tristate "PF_KEY sockets (deprecated)"
>  	select XFRM_ALGO
> +	default n
>  	help
>  	  PF_KEYv2 socket family, compatible to KAME ones.
> -	  They are required if you are going to use IPsec tools ported
> -	  from KAME.
>  
> -	  Say Y unless you know what you are doing.
> +	  The PF_KEYv2 socket interface is deprecated and
> +	  scheduled for removal. Please use the netlink
> +	  interface (XFRM_USER) to configure IPsec.
> +
> +	  If unsure, say N.
>  
>  config NET_KEY_MIGRATE
>  	bool "PF_KEY MIGRATE"
> -- 
> 2.43.0
> 
> -- 
> Devel mailing list -- devel@...ts.linux-ipsec.org
> To unsubscribe send an email to devel-leave@...ts.linux-ipsec.org