netdev - Re: [PATCH v3 net-next 0/2] ibmvnic: Fix/Improve queue stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250710101638.GO721198@horms.kernel.org>
Date: Thu, 10 Jul 2025 11:16:38 +0100
From: Simon Horman <horms@...nel.org>
To: Mingming Cao <mmc@...ux.ibm.com>
Cc: netdev@...r.kernel.org, kuba@...nel.org, bjking1@...ux.ibm.com,
	haren@...ux.ibm.com, ricklind@...ux.ibm.com, davemarq@...ux.ibm.com
Subject: Re: [PATCH v3 net-next 0/2] ibmvnic: Fix/Improve queue stats

On Wed, Jul 09, 2025 at 11:40:06AM -0700, Mingming Cao wrote:
> This patch series introduces two updates to the ibmvnic driver, 
> focusing on improving the accuracy and safety of queue-level statistics.
> 
> Patch 1: Convert per-queue RX/TX stats to atomic64_t to ensure thread-safe 
> updates in concurrent environments. This establishes a safe and consistent 
> foundation for subsequent statistics-related fixes. 
> 
> Patch 2: Fix inaccurate sar statistics by implementing ndo_get_stats64() and 
> removing the outdated manual updates to netdev->stats.
> 
> This series is intended for `net-next` and assumes the bug fix for hardcoded 
> `NUM_RX_STATS` and `NUM_TX_STATS` has already been included in the `net` tree.
> 
> --------------------------------------
> 
> Changes since v2:
> link to v2: https://www.spinics.net/lists/netdev/msg1104665.html
> 
> - Dropped Patch 2 from v2, which fixed the hardcoded `NUM_RX_STATS` and `NUM_TX_STATS`,
>  as suggested by Simon. https://www.spinics.net/lists/netdev/msg1106669.html
> - Updated Patch 1 in v2 to rebase on top of the above fix in `net`.
> – Patch 3 in v2 (now patch 2) unchanged.
> - Dropped Patch 4 from v2, which raised the default number of indirect sub-CRQ entries 
> and introduced a module parameter for backward compatibility. Based on review feedback, 
> plan to explore alternative ways to handle older systems without adding a module parameter.
> 

Thanks, overall this looks good to me.

I think you need to repost this patchset once [1] is present in net-next.

[1] [PATCH net] ibmvnic: Fix hardcoded NUM_RX_STATS/NUM_TX_STATS with dynamic sizeof
    https://lore.kernel.org/all/20250709153332.73892-1-mmc@linux.ibm.com/

-- 
pw-bot: deferred