netdev - Re: [TEST] net/udpgro.sh is flaky on debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0455186e-290f-41b5-b2b3-78d5bfa2b74b@redhat.com>
Date: Thu, 10 Jul 2025 16:20:28 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>, Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org
Subject: Re: [TEST] net/udpgro.sh is flaky on debug

On 7/10/25 4:09 PM, Jakub Kicinski wrote:
> net/udpgro.sh has around 6% false positive rate on the debug kernels :(
> 
> Please see:
> https://netdev.bots.linux.dev/contest.html?executor=vmksft-net-dbg&test=udpgro-sh&ld_cnt=200&pass=0
> for recent failures.
> 
> Is there anything we can do to make it more resilient ?

As most failures happen while waiting for the 'following' packets in non
GRO scenarios, a trivial attempt could increasing the inter-packet
timeout (currently 10ms).

Something alike the following. I can send a formal patch, and we can let
it stage in PW for a bit to observe if it actually helps.

/P
---
diff --git a/tools/testing/selftests/net/udpgro.sh
b/tools/testing/selftests/net/udpgro.sh
index 1dc337c709f8..43fcd4b0f6a2 100755
--- a/tools/testing/selftests/net/udpgro.sh
+++ b/tools/testing/selftests/net/udpgro.sh
@@ -48,7 +48,7 @@ run_one() {

        cfg_veth

-       ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 1000 -R 10
${rx_args} &
+       ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 1000 -R 100
${rx_args} &
        local PID1=$!

        wait_local_port_listen ${PEER_NS} 8000 udp