netdev - Re: [PATCH v1 net-next] dev: Pass netdevice_tracker to dev_get_by_flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202507110651.qJgShsUO-lkp@intel.com>
Date: Fri, 11 Jul 2025 07:05:31 +0800
From: kernel test robot <lkp@...el.com>
To: Kuniyuki Iwashima <kuniyu@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	David Ahern <dsahern@...nel.org>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	netdev@...r.kernel.org, Simon Horman <horms@...nel.org>,
	Kuniyuki Iwashima <kuniyu@...gle.com>
Subject: Re: [PATCH v1 net-next] dev: Pass netdevice_tracker to
 dev_get_by_flags_rcu().

Hi Kuniyuki,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/dev-Pass-netdevice_tracker-to-dev_get_by_flags_rcu/20250710-030425
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250709190144.659194-1-kuniyu%40google.com
patch subject: [PATCH v1 net-next] dev: Pass netdevice_tracker to dev_get_by_flags_rcu().
config: x86_64-randconfig-071-20250711 (https://download.01.org/0day-ci/archive/20250711/202507110651.qJgShsUO-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250711/202507110651.qJgShsUO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507110651.qJgShsUO-lkp@intel.com/

All errors (new ones prefixed by >>):

>> net/core/dev.c:1294:17: error: use of undeclared identifier 'dev_get_by_flags_rcu'; did you mean 'netdev_get_by_flags_rcu'?
    1294 | EXPORT_IPV6_MOD(dev_get_by_flags_rcu);
         |                 ^~~~~~~~~~~~~~~~~~~~
         |                 netdev_get_by_flags_rcu
   include/net/ip.h:693:42: note: expanded from macro 'EXPORT_IPV6_MOD'
     693 | #define EXPORT_IPV6_MOD(X) EXPORT_SYMBOL(X)
         |                                          ^
   include/linux/export.h:89:44: note: expanded from macro 'EXPORT_SYMBOL'
      89 | #define EXPORT_SYMBOL(sym)              _EXPORT_SYMBOL(sym, "")
         |                                                        ^
   include/linux/export.h:86:54: note: expanded from macro '_EXPORT_SYMBOL'
      86 | #define _EXPORT_SYMBOL(sym, license)    __EXPORT_SYMBOL(sym, license, "")
         |                                                         ^
   include/linux/export.h:76:16: note: expanded from macro '__EXPORT_SYMBOL'
      76 |         extern typeof(sym) sym;                                 \
         |                       ^
   net/core/dev.c:1280:20: note: 'netdev_get_by_flags_rcu' declared here
    1280 | struct net_device *netdev_get_by_flags_rcu(struct net *net, netdevice_tracker *tracker,
         |                    ^
   1 error generated.


vim +1294 net/core/dev.c

^1da177e4c3f415 Linus Torvalds    2005-04-16  1268  
^1da177e4c3f415 Linus Torvalds    2005-04-16  1269  /**
700489140bac828 Kuniyuki Iwashima 2025-07-09  1270   * netdev_get_by_flags_rcu - find any device with given flags
c4ea43c552ecc9c Randy Dunlap      2007-10-12  1271   * @net: the applicable net namespace
^1da177e4c3f415 Linus Torvalds    2005-04-16  1272   * @if_flags: IFF_* values
^1da177e4c3f415 Linus Torvalds    2005-04-16  1273   * @mask: bitmask of bits in if_flags to check
^1da177e4c3f415 Linus Torvalds    2005-04-16  1274   *
eb1ac9ff6c4a572 Kuniyuki Iwashima 2025-07-02  1275   * Search for any interface with the given flags.
eb1ac9ff6c4a572 Kuniyuki Iwashima 2025-07-02  1276   *
eb1ac9ff6c4a572 Kuniyuki Iwashima 2025-07-02  1277   * Context: rcu_read_lock() must be held.
eb1ac9ff6c4a572 Kuniyuki Iwashima 2025-07-02  1278   * Returns: NULL if a device is not found or a pointer to the device.
^1da177e4c3f415 Linus Torvalds    2005-04-16  1279   */
700489140bac828 Kuniyuki Iwashima 2025-07-09  1280  struct net_device *netdev_get_by_flags_rcu(struct net *net, netdevice_tracker *tracker,
700489140bac828 Kuniyuki Iwashima 2025-07-09  1281  					   unsigned short if_flags, unsigned short mask)
^1da177e4c3f415 Linus Torvalds    2005-04-16  1282  {
eb1ac9ff6c4a572 Kuniyuki Iwashima 2025-07-02  1283  	struct net_device *dev;
6c555490e0ce885 WANG Cong         2014-09-11  1284  
eb1ac9ff6c4a572 Kuniyuki Iwashima 2025-07-02  1285  	for_each_netdev_rcu(net, dev) {
eb1ac9ff6c4a572 Kuniyuki Iwashima 2025-07-02  1286  		if (((READ_ONCE(dev->flags) ^ if_flags) & mask) == 0) {
700489140bac828 Kuniyuki Iwashima 2025-07-09  1287  			netdev_hold(dev, tracker, GFP_ATOMIC);
eb1ac9ff6c4a572 Kuniyuki Iwashima 2025-07-02  1288  			return dev;
^1da177e4c3f415 Linus Torvalds    2005-04-16  1289  		}
^1da177e4c3f415 Linus Torvalds    2005-04-16  1290  	}
eb1ac9ff6c4a572 Kuniyuki Iwashima 2025-07-02  1291  
eb1ac9ff6c4a572 Kuniyuki Iwashima 2025-07-02  1292  	return NULL;
^1da177e4c3f415 Linus Torvalds    2005-04-16  1293  }
eb1ac9ff6c4a572 Kuniyuki Iwashima 2025-07-02 @1294  EXPORT_IPV6_MOD(dev_get_by_flags_rcu);
^1da177e4c3f415 Linus Torvalds    2005-04-16  1295  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki